From: Wolfram Sang <wsa@the-dreams.de>
To: Manuel Lauss <manuel.lauss@gmail.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-au1550: relax bus timings a bit
Date: Tue, 20 Oct 2015 17:44:43 +0200 [thread overview]
Message-ID: <20151020154443.GK5379@katana> (raw)
In-Reply-To: <1441695383-87868-1-git-send-email-manuel.lauss@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On Tue, Sep 08, 2015 at 08:56:23AM +0200, Manuel Lauss wrote:
> The i2c-au1550 driver has to program various setup and hold times
> for the sda/scl signals by hand. The current values seem to be
> working best when the driver is supplied with 50MHz, however on the
> DB1300 board 48MHz is the closest we can get to it, and the timings
> are a bit too tight for that, leading to the last bit of a transmission
> sometimes being swallowed. This manifests itself in wrong readings
> of the ne1619 sensor and inability to configure the wm8731 i2s codec.
>
> With the relaxed timings, both the sensor and the i2s codec can now
> be accessed more reliably over a wider range of I2C block input
> frequencies.
>
> Verified on DB1200, DB1300 and DB1550 boards.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
Applied to for-next, thanks!
Since you have access to these platforms, there is a pending devm
conversion patchneeding some testing:
http://patchwork.ozlabs.org/patch/482140/
Are you maybe interested in checking that one?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-20 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:56 [PATCH] i2c: i2c-au1550: relax bus timings a bit Manuel Lauss
2015-10-20 15:44 ` Wolfram Sang [this message]
2015-10-20 17:54 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020154443.GK5379@katana \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.