From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbbJTRc2 (ORCPT ); Tue, 20 Oct 2015 13:32:28 -0400 Received: from one.firstfloor.org ([193.170.194.197]:47601 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbJTRcW (ORCPT ); Tue, 20 Oct 2015 13:32:22 -0400 Date: Tue, 20 Oct 2015 19:32:20 +0200 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/2] x86, perf: Optimize stack walk user accesses Message-ID: <20151020173219.GI3533@two.firstfloor.org> References: <1445295269-5672-1-git-send-email-andi@firstfloor.org> <1445295269-5672-2-git-send-email-andi@firstfloor.org> <20151020110332.GB17308@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151020110332.GB17308@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Perf can call this function from !interrupt context (imagine a > tracepoint or other software event), should we therefore not add a > pagefault_disable()/enable() pair around the entire while() loop? That's true. I'll add the pagefault_disable/enable. -Andi