From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration Date: Wed, 21 Oct 2015 10:28:17 +0300 Message-ID: <20151021072817.GM1526@lahna.fi.intel.com> References: <1445323081.3380.25.camel@kxue-X58A-UD3R> <20151020111737.GF1526@lahna.fi.intel.com> <1445389893.2483.3.camel@kxue-X58A-UD3R> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1445389893.2483.3.camel@kxue-X58A-UD3R> Sender: stable-owner@vger.kernel.org To: Ken Xue Cc: baruch@tkos.co.il, SPG_Linux_Kernel@amd.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > > > DW I2C driver tries to register a clk from id->driver_data as an > > > alternative way besides intel lpss. But code doesn't register the > > > clk to clkdev. So, devm_clk_get will fail during probe. > > > > > > The patch can fix this issue. > > > > Since you now have drivers/acpi/acpi_apd.c for AMD ACPI stuff, can you > > create the clock there just like we do for Intel stuff? > Sure. APD already creates the clock for AMD0010 as you expected. And the > next patch([PATCH 2/2] i2c: designware: remove freq definition for > "AMD0010" in acpi_device_id) is dropping the old way for getting freq. So this patch is not necessary, right?