From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZonT4-0001Qn-Bv for qemu-devel@nongnu.org; Wed, 21 Oct 2015 03:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZonS5-0004U8-95 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 03:04:54 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:50380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZonS4-0004Ty-Vr for qemu-devel@nongnu.org; Wed, 21 Oct 2015 03:04:49 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Oct 2015 08:04:46 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CF4AB219005F for ; Wed, 21 Oct 2015 08:04:42 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9L74jj710682696 for ; Wed, 21 Oct 2015 07:04:45 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9L74iPM008020 for ; Wed, 21 Oct 2015 01:04:45 -0600 Date: Wed, 21 Oct 2015 09:04:43 +0200 From: David Hildenbrand Message-ID: <20151021090443.08f24b0a@thinkpad-w530> In-Reply-To: <20151020185007.12c71e72.cornelia.huck@de.ibm.com> References: <1445353225-16775-1-git-send-email-cornelia.huck@de.ibm.com> <20151020185007.12c71e72.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Peter Maydell , Alexander Graf , QEMU Developers , Jens Freimann , Christian Borntraeger > On Tue, 20 Oct 2015 16:35:44 +0100 > Peter Maydell wrote: > > > On 20 October 2015 at 16:00, Cornelia Huck wrote: > > > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: > > > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20 12:56:45 +0100) > > > > > > are available in the git repository at: > > > > > > git://github.com/cohuck/qemu tags/s390x-20151020 > > > > > > for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c: > > > > > > s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200) > > > > > > ---------------------------------------------------------------- > > > More s390x patches. The first ones are fixes: A regression, missed > > > compat and a missed part of the SIMD support. The others contain > > > optimizations and cleanup. > > > > > > ---------------------------------------------------------------- > > > > Hi; I'm afraid this fails to build with clang: > > /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12: > > error: duplicate 'const' declaration specifier > > [-Werror,-Wduplicate-decl-specifier] > > const char const *reset_dev_types[] = { > > ^ > > > > > > > > Did you mean "const char * const" ? (I always have trouble with this > > corner of C syntax...) > > Not only you... > > David, can you take a look at this? Looks like I'm also having trouble with it ;) Guess I should start to also compile with clang. yes, "const char * const" should be the right thing ... if not simply "const char *". David