All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Andrew F. Davis" <afd@ti.com>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC
Date: Wed, 21 Oct 2015 12:18:32 +0100	[thread overview]
Message-ID: <20151021111832.GC3270@x1> (raw)
In-Reply-To: <20151021102952.GJ32054@sirena.org.uk>

On Wed, 21 Oct 2015, Mark Brown wrote:

> On Wed, Oct 21, 2015 at 09:46:33AM +0100, Lee Jones wrote:
> > On Tue, 20 Oct 2015, Andrew F. Davis wrote:
> 
> > > I could change the core to be "tps65086-pmic", then call the regulator
> > > driver "tps65086-regulator" if this works for you, this seems to be the
> > > way new drivers name the regulator driver (max77843.c).
> 
> > Yes, this is what I was thinking of.
> 
> > ti,tps65086 is uninformative/undescriptive and tells me nothing.
> 
> It is however the normal way we write compatible strings - the class
> information would normaly go in the node name (ie, i2c@7000c000 or
> whatever).

I didn't say it hasn't been done before, just that I didn't like it
for the aforementioned reasons.  I can also find 1000's of compatible
strings which do append "-<device_type>", so it's not exactly an
unheard of practice.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-10-21 11:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 16:59 [PATCH 0/4] Add support for the TI TPS65086 PMIC Andrew F. Davis
2015-10-16 16:59 ` Andrew F. Davis
2015-10-16 16:59 ` [PATCH 1/4] Documentation: tps65086: Add DT bindings for the " Andrew F. Davis
2015-10-16 16:59   ` Andrew F. Davis
2015-10-19  9:13   ` Lee Jones
2015-10-19  9:13     ` Lee Jones
2015-10-19 15:16     ` Andrew F. Davis
2015-10-19 15:16       ` Andrew F. Davis
2015-10-19 15:21       ` Lee Jones
2015-10-19 15:21         ` Lee Jones
2015-10-19 15:23         ` Andrew F. Davis
2015-10-19 15:23           ` Andrew F. Davis
2015-10-20 11:31           ` Lee Jones
2015-10-20 14:02             ` Andrew F. Davis
2015-10-20 14:02               ` Andrew F. Davis
2015-10-21  8:46               ` Lee Jones
2015-10-21  8:46                 ` Lee Jones
2015-10-21 10:29                 ` Mark Brown
2015-10-21 11:18                   ` Lee Jones [this message]
2015-10-21 12:14                     ` Mark Brown
2015-10-21 15:26                       ` Lee Jones
2015-10-21 16:13                         ` Mark Brown
2015-10-16 16:59 ` [PATCH 2/4] mfd: tps65086: Add driver " Andrew F. Davis
2015-10-16 16:59   ` Andrew F. Davis
     [not found]   ` <1445014753-15450-3-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-10-19  9:23     ` Lee Jones
2015-10-19  9:23       ` Lee Jones
2015-10-19 16:03       ` Andrew F. Davis
2015-10-19 16:03         ` Andrew F. Davis
2015-10-20 10:02         ` Lee Jones
2015-10-20 10:02           ` Lee Jones
2015-10-20 14:58           ` Andrew F. Davis
2015-10-20 14:58             ` Andrew F. Davis
2015-10-21  8:43             ` Lee Jones
2015-10-21 16:28               ` Andrew F. Davis
2015-10-21 16:28                 ` Andrew F. Davis
     [not found]                 ` <5627BD11.1000704-l0cyMroinI0@public.gmane.org>
2015-10-21 19:24                   ` Lee Jones
2015-10-21 19:24                     ` Lee Jones
2015-10-16 16:59 ` [PATCH 3/4] regulator: tps65086: Add regulator " Andrew F. Davis
2015-10-16 16:59   ` Andrew F. Davis
2015-10-16 16:59 ` [PATCH 4/4] gpio: tps65086: Add GPIO " Andrew F. Davis
2015-10-16 16:59   ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151021111832.GC3270@x1 \
    --to=lee.jones@linaro.org \
    --cc=afd@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.