From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] usb: host: xhci-omap: fix build break
Date: Wed, 21 Oct 2015 07:55:36 -0400 [thread overview]
Message-ID: <20151021115536.GJ23893@bill-the-cat> (raw)
In-Reply-To: <CALeDE9M=LaYDgvMzfGSp-zL__WMR0bjxMz2BtTiTpKwWmUVKnQ@mail.gmail.com>
On Wed, Oct 21, 2015 at 09:37:13AM +0100, Peter Robinson wrote:
> >>> Felipe Balbi <balbi@ti.com> writes:
> >>> > Fix the following build break:
> >>> >
> >>> > drivers/usb/host/xhci-omap.c:35:5: error: ?board_usb_init? aliased to external symbol ?__board_usb_init?
> >>> > int board_usb_init(int index, enum usb_init_type init)
> >>> > ^
> >>> >
> >>> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >>>
> >>> ping
> >>
> >> Where / how do I trigger this (or 2/2) ?
> >
> > GCC 5
>
> I'm seeing exactly the same issue with gcc5 on Fedora, I've also seen
> another issue with gcc5 with strcat for panda board variant names
> which we hacked around [1].
So, I want to say that GCC 5.x (or at least 5.1) will be a known good
compiler for v2016.01. I know that Fedora folks have been doing it for
a while (yay, thanks) but I also know that Felipe has seen a few
problems using some other (I think..) gcc-5 toolchain. So what I'm
doing is getting the Fedora gcc-5 packages installed now, along with a
Debian/unstable chroot where I can also get at all of their cross tools.
> [1] http://pkgs.fedoraproject.org/cgit/uboot-tools.git/tree/0009-ARM-fix-pandaboard-es-and-a4-revision-ID.patch?h=f23
That's interesting. I don't know why (and I would worry about) strcat
failing, but since it's two string literals can't we just do a simple +?
Or is my lack of coffee just yet causing me to forget that C is not
every-other-language...
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151021/440bd7bb/attachment.sig>
next prev parent reply other threads:[~2015-10-21 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:22 [U-Boot] [PATCH 1/2] usb: host: xhci-omap: fix build break Felipe Balbi
2015-10-01 19:22 ` [U-Boot] [PATCH 2/2] usb: dwc3: fix build warnings Felipe Balbi
2015-10-16 20:09 ` Felipe Balbi
2015-11-28 1:30 ` Marek Vasut
2015-10-16 20:09 ` [U-Boot] [PATCH 1/2] usb: host: xhci-omap: fix build break Felipe Balbi
2015-10-16 21:35 ` Tom Rini
2015-10-16 22:08 ` Felipe Balbi
2015-10-21 8:37 ` Peter Robinson
2015-10-21 11:55 ` Tom Rini [this message]
2015-10-21 12:24 ` Peter Robinson
2015-10-21 13:09 ` Tom Rini
2015-11-28 1:33 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021115536.GJ23893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.