Re: [meta-raspberrypi][PATCH v2 4/4] README: Add a section about graphic stacks

[Andrei Gherzan <andrei@gherzan.ro>]

Hello Javier,

On Mon, Aug 24, 2015 at 10:25:30PM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> On 08/17/2015 11:58 AM, Javier Martinez Canillas wrote:
> > On 08/17/2015 09:57 AM, Andrei Gherzan wrote:
> >> On Thursday, August 13, 2015, Khem Raj <raj.khem@gmail.com> wrote:
>
> [snip]
>
> >>>>
> >>>> +2.O. Graphic stacks
> >>>> +===================
> >>>> +The Raspberry Pi boards can use one of two graphics stacks: The userland
> >>>> +user-space driver or the vc4 DRM/KMS kernel driver. By default userland
> >>>> +is used since the vc4 is still experimental. But this can be changed by
> >>>> +modifying the defaults for the kernel, egl, gles2, libgl and mesa
> >>> providers.
> >>>> +This is explained in the conf/machine/include/rpi-default-providers.inc
> >>> file.
> >>>> +
> >>>
> >>> you may want to add pointer to the commented out code that you have added
> >>> to select them
> >>> in rpi-default-providers.inc
> >>>
> >>
> >> It would be nice to have some detailed info on what and where to comment
> >> out the configuration.
> >>
> >
> > On patch 3/4 I added that documentation to rpi-default-providers but didn't
> > add it to the README and instead pointed out to rpi-default-providers to
> > have a level of indirection in case the providers change and to not have
> > duplicated information but I will add it to the README as well.
> >
> > Do you have comments on the other patches in the series so I can address
> > all of them before re-spinning?
> >
>

Really sorry on this late reply. So my only recommendation is to move things
you wrote in 3/4 in the 4/4 (README). Basically you would describe what a user
needs to overwrite as providers in order to use VC4 as graphics stack.

As well, how do you handle the devicetrees for 4.1? Aren't changed in 4+?

> Gentle ping about this. Thanks!
>
> Best regards,
> --
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America

--
Andrei Gherzan