From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Joe Stringer <joestringer@nicira.com>,
netfilter-devel@vger.kernel.org,
Linux Netdev List <netdev@vger.kernel.org>,
Andy Zhou <azhou@nicira.com>
Subject: Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag
Date: Wed, 21 Oct 2015 14:42:45 +0200 [thread overview]
Message-ID: <20151021124245.GA10299@salvia> (raw)
In-Reply-To: <20151020205306.GK4386@breakpoint.cc>
On Tue, Oct 20, 2015 at 10:53:07PM +0200, Florian Westphal wrote:
> Joe Stringer <joestringer@nicira.com> wrote:
> > > Good point. No, I don't. Any suggestions?
> > > I can try to just re-target -nf tree (sans patch #2). Pablo?
> >
> > The smallest change seems to be adding the nf_ct_frag6_consume_orig()
> > call to OVS, plus the morph logic from patch 3. Alternatively if Pablo
> > is fine with having the series re-targeted, then that sounds
> > reasonable to me too.
>
> Pablo, your call.
>
> I would suggest to re-target patches #1 and #3 to nf tree, I can do
> this, just let me know.
It's fairly late, we're on -rc6 so I don't think it's a good idea to
submit a large rework to -nf at this stage.
> Alternative is to just add the nf_ct_frag6_consume_orig call to
> openvswitch and handle that via net tree.
>
> I can then wait for that change to pop up in nf-next and just resend
> this series (which will then undo that change).
I'd rather get things fixes for the existing code. This would also
allow simple passing back to -stable, then we can move forward discuss
and review your rework with sufficient time.
Let me know, thanks!
next prev parent reply other threads:[~2015-10-21 12:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 20:14 [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 1/4] netfilter: ipv6: remove extra clone/free operations Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 2/4] inet: kill obsolete skb_free op Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb Florian Westphal
2015-10-20 18:39 ` Joe Stringer
2015-10-20 20:46 ` Florian Westphal
2015-10-17 20:14 ` [PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion Florian Westphal
2015-10-20 6:25 ` Joe Stringer
2015-10-20 8:18 ` Florian Westphal
2015-10-20 6:16 ` [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag Joe Stringer
2015-10-20 8:17 ` Florian Westphal
2015-10-20 18:43 ` Joe Stringer
2015-10-20 20:53 ` Florian Westphal
2015-10-20 23:59 ` Joe Stringer
2015-10-21 12:42 ` Pablo Neira Ayuso [this message]
2015-10-21 14:50 ` Florian Westphal
2015-10-21 16:52 ` Joe Stringer
2015-10-21 14:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021124245.GA10299@salvia \
--to=pablo@netfilter.org \
--cc=azhou@nicira.com \
--cc=fw@strlen.de \
--cc=joestringer@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.