From: Jiri Benc <jbenc@redhat.com>
To: Brenden Blanco <bblanco@plumgrid.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, maheshb@google.com
Subject: Re: [PATCH net-next] ipvlan: read direct ifindex instead of iflink
Date: Wed, 21 Oct 2015 13:26:10 +0200 [thread overview]
Message-ID: <20151021132611.436eafe6@griffin> (raw)
In-Reply-To: <20151020234732.GA16302@gmail.com>
On Tue, 20 Oct 2015 16:47:33 -0700, Brenden Blanco wrote:
> --- a/drivers/net/ipvlan/ipvlan_core.c
> +++ b/drivers/net/ipvlan/ipvlan_core.c
> @@ -348,7 +348,7 @@ static int ipvlan_process_v4_outbound(struct sk_buff *skb)
> struct rtable *rt;
> int err, ret = NET_XMIT_DROP;
> struct flowi4 fl4 = {
> - .flowi4_oif = dev_get_iflink(dev),
> + .flowi4_oif = dev->ifindex,
The current code is obviously wrong and the patch makes sense.
Reviewed-by: Jiri Benc <jbenc@redhat.com>
--
Jiri Benc
next prev parent reply other threads:[~2015-10-21 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 23:47 [PATCH net-next] ipvlan: read direct ifindex instead of iflink Brenden Blanco
2015-10-21 11:26 ` Jiri Benc [this message]
2015-10-21 18:32 ` Mahesh Bandewar
2015-10-22 13:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021132611.436eafe6@griffin \
--to=jbenc@redhat.com \
--cc=bblanco@plumgrid.com \
--cc=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.