From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] tools/xenpaging: install directory with
 default permission
Date: Wed, 21 Oct 2015 15:09:36 +0100
Message-ID: <20151021140936.GF5060@zion.uk.xensource.com>
References: <1445429422-18749-1-git-send-email-wei.liu2@citrix.com>
	<1445435214.9563.150.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=729c61eb8=wei.liu2@citrix.com>)
	id 1Zou5F-0003ZO-U8
	for xen-devel@lists.xenproject.org; Wed, 21 Oct 2015 14:09:42 +0000
Content-Disposition: inline
In-Reply-To: <1445435214.9563.150.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Oct 21, 2015 at 02:46:54PM +0100, Ian Campbell wrote:
> On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote:
> > There is no need to explicitly ask for 700.
> 
> Is the rationale for 0700 explicitly not that the files in here will
> contain possibly sensitive date from guest memory?
> 
> i.e. the use of something other than the default is deliberate.
> 

You're right. Please ignore this patch.

Wei.

> If you think that is wrong then I think the changelog should explain why.
> 
> 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  tools/xenpaging/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
> > index 2407a30..4badaae 100644
> > --- a/tools/xenpaging/Makefile
> > +++ b/tools/xenpaging/Makefile
> > @@ -24,7 +24,7 @@ xenpaging: $(OBJS)
> >  	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
> >  
> >  install: all
> > -	$(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
> > +	$(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
> >  	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> >  	$(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
> >