From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v6 1/4] of: overlay: kobjectify overlay objects Date: Wed, 21 Oct 2015 08:22:36 -0700 Message-ID: <20151021152236.GA20589@kroah.com> References: <1445368397-8732-1-git-send-email-pantelis.antoniou@konsulko.com> <1445368397-8732-2-git-send-email-pantelis.antoniou@konsulko.com> <20151020210349.GA28724@kroah.com> <302128B9-A82A-477D-A158-3283DE30F43A@konsulko.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <302128B9-A82A-477D-A158-3283DE30F43A-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pantelis Antoniou Cc: Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, Oct 21, 2015 at 04:28:33PM +0300, Pantelis Antoniou wrote: > Hi Greg, >=20 > > On Oct 21, 2015, at 00:03 , Greg Kroah-Hartman wrote: > >=20 > > On Tue, Oct 20, 2015 at 10:13:14PM +0300, Pantelis Antoniou wrote: > >> We are going to need the overlays to appear on sysfs with runtime > >> global properties (like master enable) so turn them into kobjects. > >=20 > > Why kobjects and not 'struct device=E2=80=99? > >=20 >=20 > Cause it=E2=80=99s overkill. >=20 > There is no hardware/abstract device connection between an overlay an= d a device as what=E2=80=99s being used right now in driver core. >=20 > kobjs are enough to present them in the filesystem hierarchy. >=20 > > Why even have them in sysfs at all? You need more information here= as > > to why you want to do this. > >=20 >=20 > They have to be in sysfs so that people can have information about th= e overlays applied in the system, i.e. where their targets are and whet= her removal is possible. That=E2=80=99s what=E2=80=99s possible for now= ; in the future we might present the full contents of the overlay there= , and what changes to the live tree were made. Ok, then say that in the changelog to explain what you are doing here := ) -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbbJUPWj (ORCPT ); Wed, 21 Oct 2015 11:22:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38283 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbbJUPWh (ORCPT ); Wed, 21 Oct 2015 11:22:37 -0400 Date: Wed, 21 Oct 2015 08:22:36 -0700 From: Greg Kroah-Hartman To: Pantelis Antoniou Cc: Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v6 1/4] of: overlay: kobjectify overlay objects Message-ID: <20151021152236.GA20589@kroah.com> References: <1445368397-8732-1-git-send-email-pantelis.antoniou@konsulko.com> <1445368397-8732-2-git-send-email-pantelis.antoniou@konsulko.com> <20151020210349.GA28724@kroah.com> <302128B9-A82A-477D-A158-3283DE30F43A@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <302128B9-A82A-477D-A158-3283DE30F43A@konsulko.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2015 at 04:28:33PM +0300, Pantelis Antoniou wrote: > Hi Greg, > > > On Oct 21, 2015, at 00:03 , Greg Kroah-Hartman wrote: > > > > On Tue, Oct 20, 2015 at 10:13:14PM +0300, Pantelis Antoniou wrote: > >> We are going to need the overlays to appear on sysfs with runtime > >> global properties (like master enable) so turn them into kobjects. > > > > Why kobjects and not 'struct device’? > > > > Cause it’s overkill. > > There is no hardware/abstract device connection between an overlay and a device as what’s being used right now in driver core. > > kobjs are enough to present them in the filesystem hierarchy. > > > Why even have them in sysfs at all? You need more information here as > > to why you want to do this. > > > > They have to be in sysfs so that people can have information about the overlays applied in the system, i.e. where their targets are and whether removal is possible. That’s what’s possible for now; in the future we might present the full contents of the overlay there, and what changes to the live tree were made. Ok, then say that in the changelog to explain what you are doing here :)