From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Wed, 21 Oct 2015 15:49:37 +0200 Subject: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal In-Reply-To: References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <20151020140427.GE3953@io.lakedaemon.net> <20151020160828.497fcc80@free-electrons.com> Message-ID: <20151021154937.0684666d@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thomas, On Tue, 20 Oct 2015 21:23:29 +0200 (CEST), Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Thomas Petazzoni wrote: > > As discussed on IRC, another simpler (code line wise) solution is to > > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which > > brings us back to what set_irq_flags() was doing, without actually > > reverting Rob's patch. > > I prefer that for 4.3. Done, I've proposed a patch as a reply to this e-mail. It's a one-liner. > > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the > > right long term solution, which is why I implemented what I believe is > > a (hopefully) better long term solution. > > Agreed. > > I'll go over the proposed solution tomorrow afternoon (I'm > traveling/conferencing...) Sure, no problem. I also noticed that MSI interrupts are not properly re-enabled after resume, but it's not a regression from 4.2, as I can also reproduce the issue on 4.2, so I'll handle that separately. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755038AbbJUNtk (ORCPT ); Wed, 21 Oct 2015 09:49:40 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49262 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752542AbbJUNtj (ORCPT ); Wed, 21 Oct 2015 09:49:39 -0400 Date: Wed, 21 Oct 2015 15:49:37 +0200 From: Thomas Petazzoni To: Thomas Gleixner Cc: Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tawfik Bayouk , Nadav Haklai , Lior Amsalem , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement Subject: Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Message-ID: <20151021154937.0684666d@free-electrons.com> In-Reply-To: References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <20151020140427.GE3953@io.lakedaemon.net> <20151020160828.497fcc80@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, On Tue, 20 Oct 2015 21:23:29 +0200 (CEST), Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Thomas Petazzoni wrote: > > As discussed on IRC, another simpler (code line wise) solution is to > > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which > > brings us back to what set_irq_flags() was doing, without actually > > reverting Rob's patch. > > I prefer that for 4.3. Done, I've proposed a patch as a reply to this e-mail. It's a one-liner. > > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the > > right long term solution, which is why I implemented what I believe is > > a (hopefully) better long term solution. > > Agreed. > > I'll go over the proposed solution tomorrow afternoon (I'm > traveling/conferencing...) Sure, no problem. I also noticed that MSI interrupts are not properly re-enabled after resume, but it's not a regression from 4.2, as I can also reproduce the issue on 4.2, so I'll handle that separately. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com