All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: xgifb: Replace udelay function with usleep_range
Date: Wed, 21 Oct 2015 09:07:54 -0700	[thread overview]
Message-ID: <20151021160754.GA24814@kroah.com> (raw)
In-Reply-To: <20151021153800.GA3140@navya>

On Wed, Oct 21, 2015 at 09:08:00PM +0530, Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl check:
> 
> CHECK: usleep_range is preferred over udelay
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
>  drivers/staging/xgifb/vb_init.c | 78 ++++++++++++++++++++---------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
> index 2b233af..ea358a0 100644
> --- a/drivers/staging/xgifb/vb_init.c
> +++ b/drivers/staging/xgifb/vb_init.c
> @@ -10,7 +10,7 @@ static const unsigned short XGINew_DDRDRAM_TYPE340[4][2] = {
>  	{ 16, 0x45},
>  	{  8, 0x35},
>  	{  4, 0x31},
> -	{  2, 0x21} };
> +	{  2, 0x21} };e

I don't think you build this patch :(



  reply	other threads:[~2015-10-21 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 15:38 [PATCH] Staging: xgifb: Replace udelay function with usleep_range Navya Sri Nizamkari
2015-10-21 16:07 ` Greg KH [this message]
2015-10-21 17:00   ` [Outreachy kernel] " Navya Sri Nizamkari
2015-10-21 17:00   ` Navya Sri Nizamkari
2015-10-21 19:22 ` Amitoj Kaur Chawla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151021160754.GA24814@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=navyasri.tech@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.