All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: minchan@kernel.org
Cc: linux-mm@kvack.org
Subject: re: mm: simplify reclaim path for MADV_FREE
Date: Wed, 21 Oct 2015 23:54:17 +0300	[thread overview]
Message-ID: <20151021205417.GC9839@mwanda> (raw)

Hello Minchan Kim,

The patch e4f28388eb72: "mm: simplify reclaim path for MADV_FREE"
from Oct 21, 2015, leads to the following static checker warning:

	mm/rmap.c:1469 try_to_unmap_one()
	warn: inconsistent indenting

mm/rmap.c
  1459                  /*
  1460                   * Store the swap location in the pte.
  1461                   * See handle_pte_fault() ...
  1462                   */
  1463                  VM_BUG_ON_PAGE(!PageSwapCache(page), page);
  1464                  if (swap_duplicate(entry) < 0) {
  1465                          set_pte_at(mm, address, pte, pteval);
  1466                          ret = SWAP_FAIL;
  1467                          goto out_unmap;
  1468                  }
  1469                          if (!PageDirty(page))
  1470                                  SetPageDirty(page);

My guess is that we can just remove the extra tabs.  It wasn't supposed
to be before the "goto out_unmap;" was it?

  1471                  if (list_empty(&mm->mmlist)) {
  1472                          spin_lock(&mmlist_lock);
  1473                          if (list_empty(&mm->mmlist))
  1474                                  list_add(&mm->mmlist, &init_mm.mmlist);
  1475                          spin_unlock(&mmlist_lock);
  1476                  }


regards,
dan carpenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2015-10-21 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 20:54 Dan Carpenter [this message]
2015-10-22  0:09 ` mm: simplify reclaim path for MADV_FREE Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151021205417.GC9839@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.