From: Dan Carpenter <dan.carpenter@oracle.com>
To: crope@iki.fi
Cc: linux-media@vger.kernel.org
Subject: re: [media] hackrf: add support for transmitter
Date: Wed, 21 Oct 2015 23:56:05 +0300 [thread overview]
Message-ID: <20151021205605.GE9839@mwanda> (raw)
Hello Antti Palosaari,
The patch 8bc4a9ed8504: "[media] hackrf: add support for transmitter"
from Oct 10, 2015, leads to the following static checker warning:
drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe()
error: we previously assumed 'dev' could be null (see line 1366)
drivers/media/usb/hackrf/hackrf.c
1520 dev_notice(dev->dev, "SDR API is still slightly experimental and functionality changes may follow\n");
1521 return 0;
1522 err_video_unregister_device_rx:
1523 video_unregister_device(&dev->rx_vdev);
1524 err_v4l2_device_unregister:
1525 v4l2_device_unregister(&dev->v4l2_dev);
1526 err_v4l2_ctrl_handler_free_tx:
1527 v4l2_ctrl_handler_free(&dev->tx_ctrl_handler);
1528 err_v4l2_ctrl_handler_free_rx:
1529 v4l2_ctrl_handler_free(&dev->rx_ctrl_handler);
1530 err_kfree:
1531 kfree(dev);
1532 err:
1533 dev_dbg(dev->dev, "failed=%d\n", ret);
^^^
"dev" is either freed or NULL. Also this change is basically unrelated
to adding transmitter support... :/
1534 return ret;
1535 }
regards,
dan carpenter
reply other threads:[~2015-10-21 20:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021205605.GE9839@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.