From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/915: Pad GTT views of exec objects up to user specified size
Date: Thu, 22 Oct 2015 11:09:31 +0200 [thread overview]
Message-ID: <20151022090931.GP16848@phenom.ffwll.local> (raw)
In-Reply-To: <5628A5C6.6050805@linux.intel.com>
On Thu, Oct 22, 2015 at 10:00:54AM +0100, Tvrtko Ursulin wrote:
>
> On 21/10/15 16:24, Chris Wilson wrote:
> >Our GPUs impose certain requirements upon buffers that depend upon how
> >exactly they are used. Typically this is expressed as that they require
> >a larger surface than would be naively computed by pitch * height.
> >Normally such requirements are hidden away in the userspace driver, but
> >when we accept pointers from strangers and later impose extra conditions
> >on them, the original client allocator has no idea about the
> >monstrosities in the GPU and we require the userspace driver to inform
> >the kernel how many padding pages are required beyond the client
> >allocation.
> >
> >v2: Long time, no see
> >
> >Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> As mentioned by Chris, IGT can be found as "tests/gem_exec_pad_to_size: Test
> object padding at execbuf", might need a respin for top-down allocation
> policy change.
Ah, so was just missing Testcase: line then. lgtm, Chris/Tvrtko please
push.
-Daniel
>
> And libdrm support is "libdrm_intel: Add API for execbuf pad to size
> functionality".
>
> Both patches from April this year.
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-22 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 15:24 [PATCH] drm/915: Pad GTT views of exec objects up to user specified size Chris Wilson
2015-10-22 8:04 ` Daniel Vetter
2015-10-22 8:40 ` Chris Wilson
2015-10-22 9:00 ` Tvrtko Ursulin
2015-10-22 9:09 ` Daniel Vetter [this message]
2015-10-22 14:15 ` Tvrtko Ursulin
2015-10-22 16:07 ` Chris Wilson
2015-10-23 9:50 ` Tvrtko Ursulin
2015-10-26 16:00 ` Tvrtko Ursulin
2015-10-26 17:05 ` Chris Wilson
2015-11-03 10:57 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022090931.GP16848@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.