All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-ext4@vger.kernel.org
Cc: fstests@vger.kernel.org
Subject: Test ext4/001
Date: Thu, 22 Oct 2015 11:10:17 +0200	[thread overview]
Message-ID: <20151022091017.GC14445@quack.suse.cz> (raw)

Hi,

I've checked why test ext4/001 fails for me with DAX and after some
investigation I've realized that the test assumes that
extent_max_zeroout_kb is 32 KB and thus unwritten extent will get converted
to written as a whole and not split. With DAX that doesn't happen (because
of difference between EXT4_GET_BLOCKS_ flags passed in writeback path and
DAX write path) and so the result differs.

So I was wondering how to best fix this. Either we could switch
extent_max_zeroout_kb to 0 to make the result same (but that has a slight
disadvantage that we would lose testing of the zeroout logic) or we could
increase file size so that zeroout doesn't trigger or something else?
Anyone has some idea?

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

             reply	other threads:[~2015-10-22  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22  9:10 Jan Kara [this message]
2015-10-22  9:26 ` Test ext4/001 Lukáš Czerner
2015-10-22 19:22 ` Theodore Ts'o
2015-10-22 20:23   ` Jan Kara
2015-10-25 20:41 ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151022091017.GC14445@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.