From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
xiakaixu <xiakaixu@huawei.com>,
davem@davemloft.net, acme@kernel.org, mingo@redhat.com,
masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org,
daniel@iogearbox.net, linux-kernel@vger.kernel.org,
pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org
Subject: Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling
Date: Thu, 22 Oct 2015 11:49:02 +0200 [thread overview]
Message-ID: <20151022094902.GM2508@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <56285410.3060505@huawei.com>
On Thu, Oct 22, 2015 at 11:12:16AM +0800, Wangnan (F) wrote:
> On 2015/10/22 11:09, Alexei Starovoitov wrote:
> >On 10/21/15 6:56 PM, Wangnan (F) wrote:
> >>>One alternative solution I can image is to attach a BPF program
> >>>at sampling like kprobe, and return 0 if we don't want sampling
> >>>take action. Thought?
> >>
> >>Do you think attaching BPF programs to sampling is an acceptable idea?
> >
> >If you mean to extend 'filter' concept to sampling events?
> >So instead of soft_disable of non-local events, you'll attach bpf
> >program to sampling events and use map lookup to decide whether
> >to filter out or not such sampling event?
>
> Yes.
One could overload or stack the overflow handler I suppose. But this
would be in line with the software/tracepoint events calling eBPF muck
on trigger, right?
> >What pt_regs would be in such case?
> Sampling is based on interruption. We can use pt_reg captured by the IRQ
> handler,
s/IRQ/NMI/
Also, we 'edit' the pt_regs on the way down to the overflow handler as
sometimes 'better' information can be had from PMU state. But a pt_regs
is available there.
next prev parent reply other threads:[~2015-10-22 9:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 7:22 [PATCH V5 0/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia
2015-10-20 7:22 ` [PATCH V5 1/1] " Kaixu Xia
2015-10-20 22:53 ` Alexei Starovoitov
2015-10-21 9:12 ` Peter Zijlstra
2015-10-21 10:31 ` xiakaixu
2015-10-21 11:33 ` Peter Zijlstra
2015-10-21 11:49 ` Wangnan (F)
2015-10-21 12:17 ` Peter Zijlstra
2015-10-21 13:42 ` Wangnan (F)
2015-10-21 13:49 ` Peter Zijlstra
2015-10-21 14:01 ` pi3orama
2015-10-21 14:09 ` Peter Zijlstra
2015-10-21 15:06 ` pi3orama
2015-10-21 16:57 ` Peter Zijlstra
2015-10-21 21:19 ` Alexei Starovoitov
2015-10-22 9:06 ` Peter Zijlstra
2015-10-22 10:28 ` Wangnan (F)
2015-10-23 12:52 ` Peter Zijlstra
2015-10-23 15:12 ` Peter Zijlstra
2015-10-27 6:43 ` xiakaixu
2015-10-22 2:46 ` Wangnan (F)
2015-10-22 7:39 ` Ingo Molnar
2015-10-22 7:51 ` Wangnan (F)
2015-10-22 9:24 ` Peter Zijlstra
2015-10-22 1:56 ` Wangnan (F)
2015-10-22 3:09 ` Alexei Starovoitov
2015-10-22 3:12 ` Wangnan (F)
2015-10-22 3:26 ` Alexei Starovoitov
2015-10-22 9:49 ` Peter Zijlstra [this message]
2015-10-21 11:34 ` Wangnan (F)
2015-10-21 11:56 ` Peter Zijlstra
2015-10-21 12:03 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022094902.GM2508@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.