From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964955AbbJVODQ (ORCPT ); Thu, 22 Oct 2015 10:03:16 -0400 Received: from mail.kernel.org ([198.145.29.136]:59627 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964921AbbJVODM (ORCPT ); Thu, 22 Oct 2015 10:03:12 -0400 Date: Thu, 22 Oct 2015 11:03:07 -0300 From: Arnaldo Carvalho de Melo To: Brendan Gregg Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Adrian Hunter , Borislav Petkov , Chandler Carruth , Frederic Weisbecker , Stephane Eranian , Wang Nan Subject: Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled Message-ID: <20151022140307.GG32514@kernel.org> References: <1445495330-25416-1-git-send-email-namhyung@kernel.org> <1445495330-25416-3-git-send-email-namhyung@kernel.org> <20151022073247.GA14234@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu: > On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim wrote: > > Hi Ingo, > > > > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: > >> > >> * Namhyung Kim wrote: > >> > >>> The caller callchain order is useful with --children option since it can > >>> show 'overview' style output, but other commands which don't use > >>> --children feature like 'perf script' or even 'perf report/top' without > >>> --children are better to keep caller order. > > > > Oops, there's a typo: s/caller order/callee order/ :) > > Thanks, I was wondering about that (and I've made that typo myself). > Thanks for the patch! Brendan, can I take that as an Acked-by? > Brendan