From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/9] nvme: do not restart the request timeout if we're resetting the controller
Date: Thu, 22 Oct 2015 20:17:17 +0200 [thread overview]
Message-ID: <20151022181717.GA22554@lst.de> (raw)
In-Reply-To: <B58D82457FDA0744A320A2FC5AC253B93CD26DD0@fmsmsx104.amr.corp.intel.com>
On Thu, Oct 22, 2015@05:15:18PM +0000, Busch, Keith wrote:
> But the request is available for reuse after completion. Can we
> can rely on REQ_ATOM_COMPETE when the req is allocated for a new command?
We can't. What I intended to rely on is a controller reset killing all
I/O queue state, but we still have a small race window between the return from
->timeout and the actual controller reset. I'll have to figure out a way
to mitigate that.
next prev parent reply other threads:[~2015-10-22 18:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 12:03 nvme abort and reset fixes Christoph Hellwig
2015-10-22 12:03 ` [PATCH 1/9] nvme: only add a controller to dev_list after it's been fully initialized Christoph Hellwig
2015-10-22 12:03 ` [PATCH 2/9] nvme: don't take the I/O queue q_lock in nvme_timeout Christoph Hellwig
2015-10-22 12:03 ` [PATCH 3/9] nvme: merge nvme_abort_req and nvme_timeout Christoph Hellwig
2015-10-22 12:03 ` [PATCH 4/9] nvme: do not restart the request timeout if we're resetting the controller Christoph Hellwig
2015-10-22 16:27 ` Busch, Keith
2015-10-22 16:30 ` Christoph Hellwig
2015-10-22 17:15 ` Busch, Keith
2015-10-22 18:17 ` Christoph Hellwig [this message]
2015-10-22 12:03 ` [PATCH 5/9] nvme: simplify resets Christoph Hellwig
2015-10-22 12:03 ` [PATCH 6/9] nvme: abort requests on the reqeueue list when shutting down a controller Christoph Hellwig
2015-10-22 14:44 ` Busch, Keith
2015-10-22 14:58 ` Christoph Hellwig
2015-10-22 15:16 ` Busch, Keith
2015-10-22 16:27 ` Christoph Hellwig
2015-10-22 12:03 ` [PATCH 7/9] nvme: merge probe_work and reset_work Christoph Hellwig
2015-10-22 12:03 ` [PATCH 8/9] nvme: remove dead controllers from a work item Christoph Hellwig
2015-10-22 18:10 ` Busch, Keith
2015-10-22 18:12 ` Christoph Hellwig
2015-10-22 20:36 ` Busch, Keith
2015-10-23 5:57 ` Christoph Hellwig
2015-10-23 14:51 ` Busch, Keith
2015-10-23 19:31 ` Busch, Keith
2015-10-22 12:03 ` [PATCH 9/9] nvme: switch abort_limit to an atomic_t Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022181717.GA22554@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.