From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758111AbbJVS0x (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Oct 2015 14:26:53 -0400
Received: from mail.kernel.org ([198.145.29.136]:50774 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757491AbbJVS0t (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Oct 2015 14:26:49 -0400
Date: Thu, 22 Oct 2015 15:26:43 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Scott Wood <scottwood@freescale.com>, linux-kernel@vger.kernel.org,
        Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] tools lib traceevent: Support %ps/%pS
Message-ID: <20151022182643.GA19412@kernel.org>
References: <20150831211637.GA12848@home.buserror.net>
 <20151022130729.7b0c17ee@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151022130729.7b0c17ee@gandalf.local.home>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Oct 22, 2015 at 01:07:29PM -0400, Steven Rostedt escreveu:
> 
> This fell through the abyss of my INBOX.
> 
> Arnaldo, can you take this.

Sure
 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 
> -- Steve
> 
> 
> On Mon, 31 Aug 2015 16:16:37 -0500
> Scott Wood <scottwood@freescale.com> wrote:
> 
> > Commits such as 65dd297ac25565 ("xfs: %pF is only for function
> > pointers") caused a regression because pretty_print() didn't support
> > %ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
> > %ps/%pS is supposed to do, so use the same code for %ps/%pS.
> > 
> > Addressing the incorrect %pf/%pF implementation is beyond the scope of
> > this patch.
> > 
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> > ---
> >  tools/lib/traceevent/event-parse.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index cc25f05..f05e5b0 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
> >  				else
> >  					ls = 2;
> >  
> > -				if (*(ptr+1) == 'F' ||
> > -				    *(ptr+1) == 'f') {
> > +				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
> > +				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
> >  					ptr++;
> >  					show_func = *ptr;
> >  				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {