From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 7/8] drm/i915: Grab execlist spinlock to avoid post-reset concurrency issues. Date: Fri, 23 Oct 2015 10:59:51 +0200 Message-ID: <20151023085951.GL16848@phenom.ffwll.local> References: <1444329100-19189-8-git-send-email-tomas.elf@intel.com> <1445268752-19155-1-git-send-email-tomas.elf@intel.com> <5629F2F3.2000308@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB8FB6E58F for ; Fri, 23 Oct 2015 01:59:55 -0700 (PDT) Received: by wijp11 with SMTP id p11so67543412wij.0 for ; Fri, 23 Oct 2015 01:59:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5629F2F3.2000308@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMjMsIDIwMTUgYXQgMDk6NDI6MjdBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMTkvMTAvMTUgMTY6MzIsIFRvbWFzIEVsZiB3cm90ZToKPiA+R3JhYiBl eGVjbGlzdCBsb2NrIHdoZW4gY2xlYW5pbmcgdXAgZXhlY2xpc3QgcXVldWVzIGFmdGVyIEdQVSBy ZXNldCB0byBhdm9pZAo+ID5jb25jdXJyZW5jeSBwcm9ibGVtcyBiZXR3ZWVuIHRoZSBjb250ZXh0 IGV2ZW50IGludGVycnVwdCBoYW5kbGVyIGFuZCB0aGUgcmVzZXQKPiA+cGF0aCBpbW1lZGlhdGVs eSBmb2xsb3dpbmcgYSBHUFUgcmVzZXQuCj4gPgo+ID4qIHYyIChDaHJpcyBXaWxzb24pOgo+ID5E byBleGVjbGlzdCBjaGVjayBhbmQgdXNlIHNpbXBsZXIgZm9ybSBvZiBzcGlubG9jayBmdW5jdGlv bnMuCj4gPgo+ID5TaWduZWQtb2ZmLWJ5OiBUb21hcyBFbGYgPHRvbWFzLmVsZkBpbnRlbC5jb20+ Cj4gPi0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMyArKysrKysr KysrKysrKy0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQo+ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPmluZGV4IGU1NzA2 MWEuLjJjN2EwYjcgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID5AQCAtMjc1Mywx OCArMjc1MywyMyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9yZXNldF9yaW5nX2NsZWFudXAoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkgKiBhcmUgdGhlIG9uZXMgdGhh dCBrZWVwIHRoZSBjb250ZXh0IGFuZCByaW5nYnVmZmVyIGJhY2tpbmcgb2JqZWN0cwo+ID4gIAkg KiBwaW5uZWQgaW4gcGxhY2UuCj4gPiAgCSAqLwo+ID4tCXdoaWxlICghbGlzdF9lbXB0eSgmcmlu Zy0+ZXhlY2xpc3RfcXVldWUpKSB7Cj4gPi0JCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq c3VibWl0X3JlcTsKPiA+Cj4gPi0JCXN1Ym1pdF9yZXEgPSBsaXN0X2ZpcnN0X2VudHJ5KCZyaW5n LT5leGVjbGlzdF9xdWV1ZSwKPiA+LQkJCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QsCj4g Pi0JCQkJZXhlY2xpc3RfbGluayk7Cj4gPi0JCWxpc3RfZGVsKCZzdWJtaXRfcmVxLT5leGVjbGlz dF9saW5rKTsKPiA+KwlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4gPisJCXNwaW5fbG9j a19pcnEoJnJpbmctPmV4ZWNsaXN0X2xvY2spOwo+ID4rCQl3aGlsZSAoIWxpc3RfZW1wdHkoJnJp bmctPmV4ZWNsaXN0X3F1ZXVlKSkgewo+ID4rCQkJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 ICpzdWJtaXRfcmVxOwo+ID4KPiA+LQkJaWYgKHN1Ym1pdF9yZXEtPmN0eCAhPSByaW5nLT5kZWZh dWx0X2NvbnRleHQpCj4gPi0JCQlpbnRlbF9scl9jb250ZXh0X3VucGluKHN1Ym1pdF9yZXEpOwo+ ID4rCQkJc3VibWl0X3JlcSA9IGxpc3RfZmlyc3RfZW50cnkoJnJpbmctPmV4ZWNsaXN0X3F1ZXVl LAo+ID4rCQkJCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QsCj4gPisJCQkJCWV4ZWNsaXN0 X2xpbmspOwo+ID4rCQkJbGlzdF9kZWwoJnN1Ym1pdF9yZXEtPmV4ZWNsaXN0X2xpbmspOwo+ID4K PiA+LQkJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShzdWJtaXRfcmVxKTsKPiA+KwkJCWlm IChzdWJtaXRfcmVxLT5jdHggIT0gcmluZy0+ZGVmYXVsdF9jb250ZXh0KQo+ID4rCQkJCWludGVs X2xyX2NvbnRleHRfdW5waW4oc3VibWl0X3JlcSk7Cj4gPisKPiA+KwkJCWk5MTVfZ2VtX3JlcXVl c3RfdW5yZWZlcmVuY2Uoc3VibWl0X3JlcSk7Cj4gPisJCX0KPiA+KwkJc3Bpbl91bmxvY2tfaXJx KCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKPiAKPiBDYW4ndCB0aGlzLCBpbiB0aGVvcnkgYXQgbGVh c3QsIGVuZCB1cCBjYWxsaW5nIGRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlIGluCj4gYSBjb3Vw bGUgb2YgY29kZSBwYXRocywgd2hpY2ggY2FuIHNsZWVwLCB3aGlsZSBob2xkaW5nIGEgc3Bpbmxv Y2s/Cj4gCj4gSWYgdGhpcyBjYW5ub3QgaGFwcGVuIGluIHByYWN0aWNlIGZvciBzb21lIHJlYXNv biBpdCB3b3VsZCBwcm9iYWJseSBiZSBnb29kCj4gdG8gcHV0IGEgY29tbWVudCBleHBsYWluaW5n IGl0Lgo+IAo+IE9yIEkgYW0gbWlzc2luZyBzb21ldGhpbmc/CgpJdCBjYW4gaW5kZWVkIEkgdGhp bmsuIFR2cnRrbywgc2luY2UgSSdtIG9mZiB0byBLUyBuZXh0IHdlZWsgYW5kIHlvdSBoYXZlCnB1 c2ggYWNjZXNzLCBjYW4geW91IHBscyBwdXNoIHRoZSByZXZlcnQgaWYgdGhpcyBjaGVja3Mgb3V0 PwoKVGhhbmtzLCBEYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==