From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752594AbbJWJEI (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 05:04:08 -0400
Received: from mail-wi0-f178.google.com ([209.85.212.178]:36881 "EHLO
	mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752022AbbJWJEF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 05:04:05 -0400
Date: Fri, 23 Oct 2015 11:03:59 +0200
From: Ingo Molnar <mingo@kernel.org>
To: tglx@linutronix.de, bp@suse.de, wangnan0@huawei.com, dsahern@gmail.com,
        hpa@zytor.com, namhyung@kernel.org, linux-kernel@vger.kernel.org,
        acme@redhat.com, jolsa@redhat.com, chandlerc@gmail.com,
        adrian.hunter@intel.com, a.p.zijlstra@chello.nl, eranian@google.com,
        brendan.d.gregg@gmail.com, fweisbec@gmail.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf tools: Improve call graph documents and
 help messages
Message-ID: <20151023090359.GA22437@gmail.com>
References: <1445524112-5201-2-git-send-email-namhyung@kernel.org>
 <tip-76a26549eb367f683fbb394b7246bef5dc665f8c@git.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tip-76a26549eb367f683fbb394b7246bef5dc665f8c@git.kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* tip-bot for Namhyung Kim <tipbot@zytor.com> wrote:

> Commit-ID:  76a26549eb367f683fbb394b7246bef5dc665f8c
> Gitweb:     http://git.kernel.org/tip/76a26549eb367f683fbb394b7246bef5dc665f8c
> Author:     Namhyung Kim <namhyung@kernel.org>
> AuthorDate: Thu, 22 Oct 2015 23:28:32 +0900
> Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Thu, 22 Oct 2015 16:23:19 -0300
> 
> perf tools: Improve call graph documents and help messages
> 
> The --call-graph option is complex so we should provide better guide for
> users.  Also change help message to be consistent with config option
> names.  Now perf top will show help like below:
> 
>   $ perf top --call-graph
>     Error: option `call-graph' requires a value
> 
>    Usage: perf top [<options>]
> 
>       --call-graph <record_mode[,record_size],print_type,threshold[,print_limit],order,sort_key[,branch]>
>            setup and enables call-graph (stack chain/backtrace):
> 
> 		record_mode:	call graph recording mode (fp|dwarf|lbr)
> 		record_size:	if record_mode is 'dwarf', max size of stack recording (<bytes>)
> 				default: 8192 (bytes)
> 		print_type:	call graph printing style (graph|flat|fractal|none)
> 		threshold:	minimum call graph inclusion threshold (<percent>)
> 		print_limit:	maximum number of call graph entry (<number>)
> 		order:		call graph order (caller|callee)
> 		sort_key:	call graph sort key (function|address)
> 		branch:		include last branch info to call graph (branch)

Btw., how is the last line to be interpreted? Is the 'branch' value 0/1? If yes 
then the text should probably say so? Or does the string 'branch' have to be used?

Thanks,

	Ingo