All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: implement 'inode' command V3
Date: Fri, 23 Oct 2015 11:29:46 +0200	[thread overview]
Message-ID: <20151023092946.GA752@redhat.com> (raw)
In-Reply-To: <20151022144255.GB13661@bfoster.bfoster>

Thanks for the review Brian, I'll walk over it and fix the points you mentioned.
> 
> 
> I still don't really get why we have separate -l and -s options here. It
> seems to me that the behavior of -l already gives us the information
> that -s does. Even if that's not obvious enough, the -l command could
> just print out both. For example:
> 
>       "Largest inode: 1234 (32-bit)"

I agree with you here, but, I'll let Dave answer this question, maybe he had 
some another idea for it that I'm not aware of. 

Cheers.
-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-10-23  9:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 12:31 [PATCH] xfs_io: implement 'inode' command V3 Carlos Maiolino
2015-10-22 14:42 ` Brian Foster
2015-10-23  9:29   ` Carlos Maiolino [this message]
2015-10-28  0:59     ` Dave Chinner
2015-10-30 15:17       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151023092946.GA752@redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.