From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbbJXTwF (ORCPT ); Sat, 24 Oct 2015 15:52:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56279 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbbJXTwD (ORCPT ); Sat, 24 Oct 2015 15:52:03 -0400 Date: Sat, 24 Oct 2015 21:48:26 +0200 From: Oleg Nesterov To: Markus Pargmann Cc: akpm@linux-foundation.org, balbi@ti.com, dwmw2@infradead.org, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: + signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch added to -mm tree Message-ID: <20151024194826.GA14895@redhat.com> References: <5612e95f.di8YWOS7lWDxbMSm%akpm@linux-foundation.org> <20151024191053.GA16521@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151024191053.GA16521@pengutronix.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, s/mm-commits/lkml/ On 10/24, Markus Pargmann wrote: > > On Mon, Oct 05, 2015 at 02:19:27PM -0700, akpm@linux-foundation.org wrote: > > > > Subject: signal: turn dequeue_signal_lock() into kernel_dequeue_signal() > > > > 1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This > > matches another "for kthreads only" kernel_sigaction() helper. > > > > 2. Remove the "tsk" and "mask" arguments, they are always current > > and current->blocked. And it is simply wrong if tsk != current. > > > > 3. We could also remove the 3rd "siginfo_t *info" arg but it looks > > potentially useful. However we can simplify the callers if we > > change kernel_dequeue_signal() to accept info => NULL. > > > > 4. Remove _irqsave, it is never called from atomic context. > > I just realised that this patch will conflict with a fixup patch for nbd > that will be included in rc7. > > dcc909d90ccd (nbd: Add locking for tasks) > > I think there is basically one new instance of dequeue_signal_lock() that > needs to be replaced with kernel_dequeue_signal(). Thanks! I'll send *-fix.patch to Andrew. But you know, dcc909d90ccd (nbd: Add locking for tasks) doesn't look exactly right at first glance, although I need to re-check tomorrow... One question, can sock_xmit() be called from user space? Or it is only called by kthreads? Oleg.