From: Andrei Gherzan <andrei@gherzan.ro>
To: Khem Raj <raj.khem@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH V4 3/5] userland: Adjust include location for pthreads-headers
Date: Sat, 24 Oct 2015 22:05:04 +0200 [thread overview]
Message-ID: <20151024200504.GD4459@resin> (raw)
In-Reply-To: <1443890258-14442-3-git-send-email-raj.khem@gmail.com>
On Sat, Oct 03, 2015 at 04:37:36PM +0000, Khem Raj wrote:
> vcos headers include headers like "vcos_platform.h" "vcos_futex_mutex.h"
> "vcos_platform_types.h" and these headers are different based on
> platform/OSes. e.g. OS targets that support pthreads these headers
> should come from pthreads/ folder but not for others. So one would add
> right -I option for every package that accesses them directly or
> indirectly. so if a software does #include <EGL/egl.h> then it will
> break
>
> | In file included from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/interface/vcos/vcos_assert.h:149:0,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/interface/vcos/vcos.h:114,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/interface/vmcs_host/vc_dispmanx.h:33,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/EGL/eglplatform.h:110,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/EGL/egl.h:36,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/work/armv7at2hf-vfp-neon-angstrom-linux-gnueabi/weston/1.8.0-r0/weston-1.8.0/clients/../shared/platform.h:29,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/work/armv7at2hf-vfp-neon-angstrom-linux-gnueabi/weston/1.8.0-r0/weston-1.8.0/clients/window.h:33,
> | from
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/work/armv7at2hf-vfp-neon-angstrom-linux-gnueabi/weston/1.8.0-r0/weston-1.8.0/clients/eventdemo.c:40:
> |
> /mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/raspberrypi2/usr/include/interface/vcos/vcos_types.h:38:33:
> fatal error: vcos_platform_types.h: No such file or directory
> | #include "vcos_platform_types.h"
> | ^
> | compilation terminated.
>
> This is wrong, it should not happen since doing simple #include
> <EGL/egl.h> should not demand manual addition of some internal paths
> tobe added to -I flags.
>
> This patch fixes the headers which refer to headers inside pthreads/
> folder to prefix them with pthreads/ so we dont have to specify
> additional paths
>
> This fixes weston on rpi and I believe there are more patches now to
>
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> recipes-multimedia/omxplayer/omxplayer_git.bb
>
> which can be removed as well
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
Merged to master. Thank you Khem.
--
Andrei Gherzan
next prev parent reply other threads:[~2015-10-24 20:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 16:37 [meta-raspberrypi][PATCH V4 1/5] userland: Fix install prefix and generate pkgconfigs Khem Raj
2015-10-03 16:37 ` [meta-raspberrypi][PATCH V4 2/5] userland: Add wayland support Khem Raj
2015-10-03 16:37 ` [meta-raspberrypi][PATCH V4 3/5] userland: Adjust include location for pthreads-headers Khem Raj
2015-10-24 20:05 ` Andrei Gherzan [this message]
2015-10-03 16:37 ` [meta-raspberrypi][PATCH V4 4/5] weston: Enable rpi compositor backend Khem Raj
2015-10-03 16:37 ` [meta-raspberrypi][PATCH V4 5/5] userland: Fix build with clang compiler Khem Raj
2015-10-03 18:24 ` [meta-raspberrypi][PATCH V4 1/5] userland: Fix install prefix and generate pkgconfigs Andrei Gherzan
2015-10-03 19:00 ` Khem Raj
2015-10-03 19:03 ` Andrei Gherzan
2015-10-03 19:15 ` Khem Raj
2015-10-03 19:18 ` Andrei Gherzan
2015-10-03 20:06 ` Khem Raj
2015-10-03 20:11 ` Andrei Gherzan
2015-10-03 20:31 ` Khem Raj
2015-10-03 20:33 ` Andrei Gherzan
2015-10-03 20:40 ` Andrei Gherzan
2015-10-03 20:45 ` Khem Raj
2015-10-03 20:46 ` Andrei Gherzan
2015-10-03 21:27 ` Andrei Gherzan
2015-10-03 21:47 ` Khem Raj
2015-10-03 21:53 ` Andrei Gherzan
2015-10-13 0:14 ` Joachim Schiele
2015-10-13 17:13 ` Andrei Gherzan
2015-10-15 14:57 ` Joachim Schiele
2015-10-21 12:05 ` Andrei Gherzan
2015-10-24 19:56 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151024200504.GD4459@resin \
--to=andrei@gherzan.ro \
--cc=raj.khem@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.