From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/2] allow LED initialization without STATUS_LED_BOOT
Date: Sat, 24 Oct 2015 17:14:56 -0400 [thread overview]
Message-ID: <20151024211456.GH23893@bill-the-cat> (raw)
In-Reply-To: <1440162801-27754-3-git-send-email-bernhard.nortmann@web.de>
On Fri, Aug 21, 2015 at 03:13:21PM +0200, Bernhard Nortmann wrote:
> For current U-Boot to initialize status LEDs via status_led_init(), it
> is required to have both CONFIG_STATUS_LED and STATUS_LED_BOOT defined.
> This may be a particular concern with GPIO LEDs, where __led_init() is
> required to correctly set up the GPIO (gpio_request and
> gpio_direction_output). Without STATUS_LED_BOOT the initialization isn't
> called, which could leave the user with a non-functional "led" command -
> due to the fact that the LED routines in gpio_led.c use gpio_set_value()
> just fine, but the GPIO never got set up properly in the first place.
>
> I think having CONFIG_STATUS_LED is sufficient to justify a
> corresponding call to status_led_init(), even with no STATUS_LED_BOOT
> defined. To do so, common/board_r.c needs call that routine, so it now
> is exposed via status_led.h.
>
> Signed-off-by: Bernhard Nortmann <bernhard.nortmann@web.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151024/b11f715f/attachment.sig>
prev parent reply other threads:[~2015-10-24 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 13:13 [U-Boot] [PATCH 0/2] GPIO LED improvements (resend) Bernhard Nortmann
2015-08-21 13:13 ` [U-Boot] [PATCH 1/2] add generic stubs for GPIO LEDs Bernhard Nortmann
2015-08-23 21:21 ` Simon Glass
2015-08-24 9:51 ` Bernhard Nortmann
2015-08-28 15:00 ` Tom Rini
2015-09-01 17:37 ` Bernhard Nortmann
2015-10-24 21:14 ` [U-Boot] [U-Boot,1/2] " Tom Rini
2015-08-21 13:13 ` [U-Boot] [PATCH 2/2] allow LED initialization without STATUS_LED_BOOT Bernhard Nortmann
2015-10-24 21:14 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151024211456.GH23893@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.