All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3] staging: lustre: Replace sscanf with kstrtoint
Date: Sat, 24 Oct 2015 18:40:45 -0700	[thread overview]
Message-ID: <20151025014045.GD8425@kroah.com> (raw)
In-Reply-To: <1445287733-17493-1-git-send-email-cristina.moraru09@gmail.com>

On Mon, Oct 19, 2015 at 11:48:53PM +0300, Cristina Moraru wrote:
> Replace single variable sscanf with specialized function
> kstrtoint at the suggestion of checkpatch.pl, to fix
> 'WARNING: Prefer kstrto<type> to single variable sscanf'
> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> 
> Changes in v2:
>   - Change error code handling.
> Changes in v3:
>   - Remove unnecessary braces
> ---

The "Changes..." lines need to go below the --- line, otherwise git will
add them to the changelog, which we don't want.

Can you fix this and resend?

thanks,

greg k-h


  reply	other threads:[~2015-10-25  8:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 13:02 [PATCH] staging: lustre: Replace sscanf with kstrtoint Cristina Moraru
2015-10-18 16:51 ` [Outreachy kernel] " Daniel Baluta
2015-10-18 21:41 ` [PATCH v2] " Cristina Moraru
2015-10-19  5:26   ` [Outreachy kernel] " Julia Lawall
2015-10-19 20:48 ` [PATCH v3] " Cristina Moraru
2015-10-25  1:40   ` Greg KH [this message]
2015-10-26 22:30 ` Cristina Moraru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151025014045.GD8425@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cristina.moraru09@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.