Re: [Outreachy kernel] [PATCH 2/3] Staging: lustre: Replace LPROCFS_CLIMP_EXIT with lprocfs_climp_exit

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Oct 21, 2015 at 11:20:34PM +0200, Ksenija Stanojevic wrote:
> Static inline functions are preferred over macros. The function is
> placed in obd_class.h instead lprocfs_status.h because obd_class.h
> includes header obd.h which contains definition of struct obd_device
> and in that way avoids build error: Dereferencing pointer to incomplete
> type.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h       |  5 +++++
>  drivers/staging/lustre/lustre/mgc/mgc_request.c         |  2 +-
>  drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 12 ++++++------
>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c     |  6 +++---
>  4 files changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 56c2096..ad15a10 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -262,6 +262,11 @@ static inline int lprocfs_climp_check(struct obd_device *obd)
>  	return 0;
>  }
>  
> +static inline void lprocfs_climp_exit(struct obd_device *obd)
> +{
> +	up_read(&(obd)->u.cli.cl_sem);
> +}

Why not just use up_read() everywhere instead?  You'll just be removing
this wrapper function in a later patch anyway :)

thanks,

greg k-h