From: Greg KH <gregkh@linuxfoundation.org>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/3] Staging: lustre: Remove unused macros
Date: Sat, 24 Oct 2015 18:51:42 -0700 [thread overview]
Message-ID: <20151025015142.GE536@kroah.com> (raw)
In-Reply-To: <c283335f7c43aaa0fe8794045742d0be4bae0c18.1445462106.git.ksenija.stanojevic@gmail.com>
On Wed, Oct 21, 2015 at 11:21:53PM +0200, Ksenija Stanojevic wrote:
> Macros LPROCFS_CLIMP_CHECK and LPROCFS_CLIMP_EXIT are not used anymore,
> therefore remove them along with the comment.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lprocfs_status.h | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lprocfs_status.h b/drivers/staging/lustre/lustre/include/lprocfs_status.h
> index 6e41129..532d195 100644
> --- a/drivers/staging/lustre/lustre/include/lprocfs_status.h
> +++ b/drivers/staging/lustre/lustre/include/lprocfs_status.h
> @@ -626,19 +626,6 @@ void lprocfs_stats_collect(struct lprocfs_stats *stats, int idx,
> int lprocfs_single_release(struct inode *, struct file *);
> int lprocfs_seq_release(struct inode *, struct file *);
>
> -/* You must use these macros when you want to refer to
> - * the import in a client obd_device for a lprocfs entry */
> -#define LPROCFS_CLIMP_CHECK(obd) do { \
> - typecheck(struct obd_device *, obd); \
Note, when you turn this into an inline function, you don't need the
typecheck() call anymore, right?
thanks,
greg k-h
prev parent reply other threads:[~2015-10-25 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 21:18 [PATCH 0/3] Staging: lustre: Replace macros with static inline functions Ksenija Stanojevic
2015-10-21 21:19 ` [PATCH 1/3] Staging: lustre: Replace LPROCFS_CLIMP_CHECK with lprocfs_climp_check Ksenija Stanojevic
2015-10-25 1:50 ` [Outreachy kernel] " Greg KH
2015-10-21 21:20 ` [PATCH 2/3] Staging: lustre: Replace LPROCFS_CLIMP_EXIT with lprocfs_climp_exit Ksenija Stanojevic
2015-10-25 1:51 ` [Outreachy kernel] " Greg KH
2015-10-21 21:21 ` [PATCH 3/3] Staging: lustre: Remove unused macros Ksenija Stanojevic
2015-10-25 1:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025015142.GE536@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.