From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH 1/3] staging: rdma: hfi1: Use setup_timer
Date: Sat, 24 Oct 2015 19:00:05 -0700 [thread overview]
Message-ID: <20151025020005.GC30763@kroah.com> (raw)
In-Reply-To: <1445653685-3137-1-git-send-email-falakreyaz@gmail.com>
On Sat, Oct 24, 2015 at 07:58:05AM +0530, Muhammad Falak R Wani wrote:
> Use the timer API function setup_timer instead of init_timer, removing
> the structure field assignments.
>
> <smpl>
>
> @timer@
> expression e1,e2,e3,fn_ptr;
> @@
> -init_timer(&e1);
> +setup_timer(&e1, fn_ptr, e2);
> ... when != fn_ptr = e3
> -e1.function = fn_ptr;
> -e1.data = e2;
>
> </smpl>
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/staging/rdma/hfi1/chip.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Again, 3 patches, all with the same subject, not good :(
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rdma: hfi1: Use setup_timer
Date: Sat, 24 Oct 2015 19:00:05 -0700 [thread overview]
Message-ID: <20151025020005.GC30763@kroah.com> (raw)
In-Reply-To: <1445653685-3137-1-git-send-email-falakreyaz@gmail.com>
On Sat, Oct 24, 2015 at 07:58:05AM +0530, Muhammad Falak R Wani wrote:
> Use the timer API function setup_timer instead of init_timer, removing
> the structure field assignments.
>
> <smpl>
>
> @timer@
> expression e1,e2,e3,fn_ptr;
> @@
> -init_timer(&e1);
> +setup_timer(&e1, fn_ptr, e2);
> ... when != fn_ptr = e3
> -e1.function = fn_ptr;
> -e1.data = e2;
>
> </smpl>
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/staging/rdma/hfi1/chip.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Again, 3 patches, all with the same subject, not good :(
next prev parent reply other threads:[~2015-10-25 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 2:28 [PATCH 1/3] staging: rdma: hfi1: Use setup_timer Muhammad Falak R Wani
2015-10-24 2:28 ` Muhammad Falak R Wani
2015-10-25 2:00 ` Greg Kroah-Hartman [this message]
2015-10-25 2:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025020005.GC30763@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=falakreyaz@gmail.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.