Re: [Outreachy kernel] [PATCH 2/3] staging: sm750fb: Remove volatile modifier

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 18, 2015 at 09:30:13PM +0530, Amitoj Kaur Chawla wrote:
> 'volatile' is not needed for regular variable. Problem found using checkpatch.pl
> WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered -harmful.txt
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 52fe945..68eef34 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -15,9 +15,9 @@ extern int smi_indent;
>  
>  struct lynx_accel {
>  	/* base virtual address of DPR registers */
> -	volatile unsigned char __iomem *dprBase;
> +	unsigned char __iomem *dprBase;
>  	/* base virtual address of de data port */
> -	volatile unsigned char __iomem *dpPortBase;
> +	unsigned char __iomem *dpPortBase;
>  
>  	/* function fointers */
>  	void (*de_init)(struct lynx_accel *);
> @@ -79,7 +79,7 @@ struct lynx_cursor {
>  	char __iomem *vstart;
>  	int offset;
>  	/* mmio addr of hw cursor */
> -	volatile char __iomem *mmio;
> +	char __iomem *mmio;

Have you verified that the code is still working properly?  Sometimes
this isn't as simple as just deleting the modifier :(

thanks,

greg k-h