Re: [Outreachy kernel] [PATCH 1/3] staging: rts5208: Fix endian sparse warnings

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Oct 22, 2015 at 12:29:30AM +0530, Amitoj Kaur Chawla wrote:
> Fix bug found using sparse which gives the following warning:
> 
> drivers/staging/rts5208/rtsx_transport.c:217:34: warning: incorrect
> type in assignment (different base types)
> drivers/staging/rts5208/rtsx_transport.c:217:34: expected unsigned int
> [unsigned] [usertype] <noident>
> drivers/staging/rts5208/rtsx_transport.c:217:34: got restricted __le32
> [usertype] <noident>
> drivers/staging/rts5208/rtsx_transport.c:316:44: warning: incorrect
> type in assignment (different base types)
> drivers/staging/rts5208/rtsx_transport.c:316:44: expected unsigned
> long long [unsigned] [long] [long long] [usertype] <noident>
> drivers/staging/rts5208/rtsx_transport.c:316:44: got restricted __le64
> [usertype] <noident>
> drivers/staging/rts5208/rtsx_transport.c:316:44: warning: incorrect
> type in assignment (different base types)
> drivers/staging/rts5208/rtsx_transport.c:316:44: expected unsigned
> long long [unsigned] [long] [long long] [usertype] <noident>
> drivers/staging/rts5208/rtsx_transport.c:316:44: got restricted __le64
> [usertype] <noident>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx_transport.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index f27491e..a650498 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -204,7 +204,7 @@ Handle_Errors:
>  void rtsx_add_cmd(struct rtsx_chip *chip,
>  		u8 cmd_type, u16 reg_addr, u8 mask, u8 data)
>  {
> -	u32 *cb = (u32 *)(chip->host_cmds_ptr);
> +	__le32 *cb = (__le32 *)(chip->host_cmds_ptr);

Why __le32?


>  	u32 val = 0;
>  
>  	val |= (u32)(cmd_type & 0x03) << 30;
> @@ -297,7 +297,7 @@ finish_send_cmd:
>  static inline void rtsx_add_sg_tbl(
>  	struct rtsx_chip *chip, u32 addr, u32 len, u8 option)
>  {
> -	u64 *sgb = (u64 *)(chip->host_sg_tbl_ptr);
> +	__le64 *sgb = (__le64 *)(chip->host_sg_tbl_ptr);

Why __le64?

thanks,

greg k-h