From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6207450266150633472 X-Received: by 10.182.72.166 with SMTP id e6mr25505927obv.47.1445762162092; Sun, 25 Oct 2015 01:36:02 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.109.138 with SMTP id l10ls1101133qgf.36.gmail; Sun, 25 Oct 2015 01:36:01 -0700 (PDT) X-Received: by 10.140.233.208 with SMTP id e199mr24732292qhc.8.1445762161635; Sun, 25 Oct 2015 01:36:01 -0700 (PDT) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id pe1si3031912pac.2.2015.10.25.01.36.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Oct 2015 01:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (unknown [58.123.138.205]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E8B5C67; Sun, 25 Oct 2015 08:36:00 +0000 (UTC) Date: Sat, 24 Oct 2015 19:40:29 -0700 From: Greg KH To: Alison Schofield Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2 1/5] staging: r8723au: break parameter list at separators and align to open braces Message-ID: <20151025024029.GA16589@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) On Tue, Oct 20, 2015 at 11:01:58PM -0700, Alison Schofield wrote: > Improve readability by aligning the struct cmd_hdl wlancmds[] to fit > within 80 chars and cleaning up the adjacent index comments. > > Addresses checkpatch.pl WARNING: line over 80 characters > > Signed-off-by: Alison Schofield > --- > drivers/staging/rtl8723au/core/rtw_cmd.c | 64 +++++++++++++++++++------------- > 1 file changed, 38 insertions(+), 26 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c > index 46aea16..c3579ac 100644 > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c > @@ -22,7 +22,7 @@ > #include > > static struct cmd_hdl wlancmds[] = { > - GEN_DRV_CMD_HANDLER(0, NULL) /*0*/ > + GEN_DRV_CMD_HANDLER(0, NULL) /*0*/ > GEN_DRV_CMD_HANDLER(0, NULL) > GEN_DRV_CMD_HANDLER(0, NULL) > GEN_DRV_CMD_HANDLER(0, NULL) > @@ -32,18 +32,26 @@ static struct cmd_hdl wlancmds[] = { > GEN_MLME_EXT_HANDLER(0, NULL) > GEN_MLME_EXT_HANDLER(0, NULL) > GEN_MLME_EXT_HANDLER(0, NULL) > - GEN_MLME_EXT_HANDLER(0, NULL) /*10*/ > + GEN_MLME_EXT_HANDLER(0, NULL) /*10*/ > GEN_MLME_EXT_HANDLER(0, NULL) > GEN_MLME_EXT_HANDLER(0, NULL) > GEN_MLME_EXT_HANDLER(0, NULL) > - GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), join_cmd_hdl23a) /*14*/ > - GEN_MLME_EXT_HANDLER(sizeof(struct disconnect_parm), disconnect_hdl23a) > - GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), createbss_hdl23a) > - GEN_MLME_EXT_HANDLER(sizeof(struct setopmode_parm), setopmode_hdl23a) > - GEN_MLME_EXT_HANDLER(sizeof(struct sitesurvey_parm), sitesurvey_cmd_hdl23a) /*18*/ > - GEN_MLME_EXT_HANDLER(sizeof(struct setauth_parm), setauth_hdl23a) > - GEN_MLME_EXT_HANDLER(sizeof(struct setkey_parm), setkey_hdl23a) /*20*/ > - GEN_MLME_EXT_HANDLER(sizeof(struct set_stakey_parm), set_stakey_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), > + join_cmd_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct disconnect_parm), > + disconnect_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct wlan_bssid_ex), > + createbss_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct setopmode_parm), > + setopmode_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct sitesurvey_parm), > + sitesurvey_cmd_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct setauth_parm), > + setauth_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct setkey_parm), /*20*/ > + setkey_hdl23a) > + GEN_MLME_EXT_HANDLER(sizeof(struct set_stakey_parm), > + set_stakey_hdl23a) This seems harder to read to me than before, how about you?