From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbbJYOax (ORCPT ); Sun, 25 Oct 2015 10:30:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56668 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbbJYOaO (ORCPT ); Sun, 25 Oct 2015 10:30:14 -0400 Date: Sun, 25 Oct 2015 16:26:37 +0100 From: Oleg Nesterov To: Andrew Morton , Markus Pargmann Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH -mm 1/3] nbd: nbd_thread_send: remove the unnecessary kernel_dequeue_signal() Message-ID: <20151025152637.GA1399@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151025152625.GA1385@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nbd_thread_send() does kernel_dequeue_signal() at the end for no reason, it is fine to exit with the pending SIGKILL. Not sure it really needs another kernel_dequeue_signal() inside the main loop, we know that signal_pending() means SIGKILL. But probably we want to clear TIF_SIGPENDING before sock_shutdown(). Signed-off-by: Oleg Nesterov --- drivers/block/nbd.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index b85e7a0..e5d96e5 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -586,10 +586,6 @@ static int nbd_thread_send(void *data) nbd->task_send = NULL; spin_unlock_irqrestore(&nbd->tasks_lock, flags); - /* Clear maybe pending signals */ - if (signal_pending(current)) - kernel_dequeue_signal(NULL); - return 0; } -- 1.5.5.1