From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 05/10] block: Introduce "drained begin/end" API
Date: Mon, 26 Oct 2015 09:42:33 +0800 [thread overview]
Message-ID: <20151026014233.GC28904@ad.usersys.redhat.com> (raw)
In-Reply-To: <20151023152452.GG5977@stefanha-x1.localdomain>
On Fri, 10/23 16:24, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 11:08:09AM +0800, Fam Zheng wrote:
> > +/**
> > + * bdrv_drained_begin:
> > + *
> > + * Begin a quiesced section for exclusive access to the BDS, by disabling
> > + * external request sources including NBD server and device model. Note that
> > + * this doesn't block timers or coroutines from submitting more requests, which
> > + * means block_job_pause is still necessary.
>
> How is the 'transaction' command protected from block jobs? Maybe I
> missed a block_job_pause() call that you added in this series...
There is no block job that can change guest visible data now, and we don't
support multiple block jobs on one BDS. That's why a call wasn't added in this
series. The comment actually is speaking generally for potential callers other
than qmp_transaction.
Fam
next prev parent reply other threads:[~2015-10-26 1:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 3:08 [Qemu-devel] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 01/10] aio: Add "is_external" flag for event handlers Fam Zheng
2015-10-23 14:58 ` Stefan Hajnoczi
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 02/10] nbd: Mark fd handlers client type as "external" Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 03/10] dataplane: Mark host notifiers' " Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 04/10] aio: introduce aio_{disable, enable}_external Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 05/10] block: Introduce "drained begin/end" API Fam Zheng
2015-10-23 15:13 ` Stefan Hajnoczi
2015-10-26 1:35 ` Fam Zheng
2015-10-23 15:24 ` Stefan Hajnoczi
2015-10-26 1:42 ` Fam Zheng [this message]
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 06/10] block: Add "drained begin/end" for transactional external snapshot Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 07/10] block: Add "drained begin/end" for transactional backup Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 08/10] block: Add "drained begin/end" for transactional blockdev-backup Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 09/10] block: Add "drained begin/end" for internal snapshot Fam Zheng
2015-10-23 3:08 ` [Qemu-devel] [PATCH v7 10/10] tests: Add test case for aio_disable_external Fam Zheng
2015-10-23 11:44 ` [Qemu-devel] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Kevin Wolf
2015-10-23 15:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026014233.GC28904@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.