Re: [Outreachy kernel] [PATCH 4/4] staging: r8723au: remove external function declarations from .c file

[Alison Schofield <amsfield22@gmail.com>]

On Sun, Oct 25, 2015 at 08:36:42AM +0100, Julia Lawall wrote:
> On Sat, 24 Oct 2015, Alison Schofield wrote:
> 
> > Remove unused external function declarations.
> > 
> > Addresses checkpatch.pl:
> > WARNING: externs should be avoided in .c files
> > 
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_efuse.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> > index bf27ea4..906b578 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> > @@ -274,7 +274,6 @@ u8 EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
> >  }
> >  
> >  /* Copy from WMAC fot EFUSE write 1 byte. */
> > -void EFUSE_Write1Byte(struct rtw_adapter *Adapter, u16 Address, u8 Value);
> 
> Are these really external declarations?
> 
> julia
>

No, they are fwd declarations...guessing some artifact.  I'll update the 
commit msg and resend. Thanks. 

> >  void EFUSE_Write1Byte(struct rtw_adapter *Adapter, u16 Address, u8 Value)
> >  {
> >  	u8	Bytetemp = {0x00};
> > @@ -502,7 +501,6 @@ int rtw_BT_efuse_map_read23a(struct rtw_adapter *padapter,
> >  }
> >  
> >  /* Read All Efuse content */
> > -void Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse);
> >  void Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse)
> >  {
> >  	u16	mapLen = 0;
> > -- 
> > 2.1.4
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a039d39e612445309cc6263707209995cb3cc071.1445752141.git.amsfield22%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >