From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753293AbbJZHsx (ORCPT ); Mon, 26 Oct 2015 03:48:53 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37125 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbbJZHsw (ORCPT ); Mon, 26 Oct 2015 03:48:52 -0400 Date: Mon, 26 Oct 2015 08:48:48 +0100 From: Markus Pargmann To: Oleg Nesterov Cc: Andrew Morton , nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm 1/3] nbd: nbd_thread_send: remove the unnecessary kernel_dequeue_signal() Message-ID: <20151026074848.GF16521@pengutronix.de> References: <20151025152625.GA1385@redhat.com> <20151025152637.GA1399@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tmoQ0UElFV5VgXgH" Content-Disposition: inline In-Reply-To: <20151025152637.GA1399@redhat.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:45:22 up 36 days, 21:06, 161 users, load average: 0.92, 0.67, 0.91 User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tmoQ0UElFV5VgXgH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 25, 2015 at 04:26:37PM +0100, Oleg Nesterov wrote: > nbd_thread_send() does kernel_dequeue_signal() at the end for no reason, > it is fine to exit with the pending SIGKILL. >=20 > Not sure it really needs another kernel_dequeue_signal() inside the > main loop, we know that signal_pending() means SIGKILL. But probably > we want to clear TIF_SIGPENDING before sock_shutdown(). Yes, I don't think it would be good to go into a tcp socket shutdown with a pending signal although I don't know if this would make difficulties. I will apply the patch to my tree and send it out as pull request to Jens as usual. Thanks, Markus >=20 > Signed-off-by: Oleg Nesterov > --- > drivers/block/nbd.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index b85e7a0..e5d96e5 100644 > --- a/drivers/block/nbd.c > +++ b/drivers/block/nbd.c > @@ -586,10 +586,6 @@ static int nbd_thread_send(void *data) > nbd->task_send =3D NULL; > spin_unlock_irqrestore(&nbd->tasks_lock, flags); > =20 > - /* Clear maybe pending signals */ > - if (signal_pending(current)) > - kernel_dequeue_signal(NULL); > - > return 0; > } > =20 > --=20 > 1.5.5.1 >=20 >=20 --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --tmoQ0UElFV5VgXgH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWLdrgAAoJEEpcgKtcEGQQcK4P/2mk0S2UBesYdWos69uBS481 5OXUl9fEddi0+6DRz4PDQwy5Jjwd7VYG9zALW1Oq2X6/f2TONbRsrrXChRiKXZ8m 8lGnTP0zoAcDlRqMyEusCoLvwUU+nEfl8J6vTFPk8k6O9qD5PRb/AUm4H4nNFCT4 MEbki6xAKA00QTFi7lQdAcNrF16JxLHhnp3m3d9Nc94zIB8YLSxvVlf4RF+kbRLO 4Fqmo2SrLyw7xTUo075AAiQ8/RbQWlVpYORiQmieeYjU0Ys1uLdTyMJOE9F+gFWl tqmn8n5PIj1RA90XlRTdyrQJCCzCmshynhOdwhYBO3HOWrwi0CSIQNskncD8YasW 8TLikMPggi1TS3QRthgLRsAQ6yvy5wU9AxqS2T3Gpa3q8RqIQ/8dGfybPbxp9uq1 zu0XoUFu4WBh/Yd6KBNCjouqdN2xqVhQqOKdWqiBIec/tY0Tftu8QsIGNwL7iLd6 VsLCQvY7DRFDE7HVi8IwPCeDhNikASqfWMudLkibeqpYmANZ+Tu9AhLLmEt+21C0 mggPzbb8Y9KHV/RKeDj0ckiHeGq9JkCuDmJvVPxXOW3yyq+VV9lM7KzGmSvAfDU0 2hlCZI72BUQvA4AefQlG/QB5VawQvZIgq/TL3DGUp4UZit82trT46OtyJq95X7FP 7c2VQ9qSwlGLDi7Xusct =MRAh -----END PGP SIGNATURE----- --tmoQ0UElFV5VgXgH--