From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH] ASoC: wm8962: set ALC2 as non-volatile register Date: Mon, 26 Oct 2015 08:40:13 +0000 Message-ID: <20151026084013.GG10520@ck-lbox> References: <1445577528-2354-1-git-send-email-jiada_wang@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1445577528-2354-1-git-send-email-jiada_wang@mentor.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiada Wang Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Oct 23, 2015 at 02:18:48PM +0900, Jiada Wang wrote: > Previously ALC2 register is set as a volatile register, declare > it as one of ALC Coefficients register together with other non-volatile > registers will cause issue, in case wm8962 has enter suspend mode, > and cache_only flag is set, any attempt to read from ALC2 will fail. > > Because the 5 status bits in ALC2 aren't used anywhere nor are useful > to end user, so this patch removes ALC2 register from volatile > register list to make ALC2 be possible to be accessed when cache_only > flag is set. > > Signed-off-by: Jiada Wang > --- Acked-by: Charles Keepax Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbbJZI5r (ORCPT ); Mon, 26 Oct 2015 04:57:47 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:41148 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbbJZI5p (ORCPT ); Mon, 26 Oct 2015 04:57:45 -0400 Date: Mon, 26 Oct 2015 08:40:13 +0000 From: Charles Keepax To: Jiada Wang CC: , , , , , , Subject: Re: [PATCH] ASoC: wm8962: set ALC2 as non-volatile register Message-ID: <20151026084013.GG10520@ck-lbox> References: <1445577528-2354-1-git-send-email-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1445577528-2354-1-git-send-email-jiada_wang@mentor.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-26_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510260159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2015 at 02:18:48PM +0900, Jiada Wang wrote: > Previously ALC2 register is set as a volatile register, declare > it as one of ALC Coefficients register together with other non-volatile > registers will cause issue, in case wm8962 has enter suspend mode, > and cache_only flag is set, any attempt to read from ALC2 will fail. > > Because the 5 status bits in ALC2 aren't used anywhere nor are useful > to end user, so this patch removes ALC2 register from volatile > register list to make ALC2 be possible to be accessed when cache_only > flag is set. > > Signed-off-by: Jiada Wang > --- Acked-by: Charles Keepax Thanks, Charles