All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Gherzan <andrei@gherzan.ro>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH v2] qtbase: enable Raspberry Pi support
Date: Mon, 26 Oct 2015 10:15:49 +0100	[thread overview]
Message-ID: <20151026091549.GA19633@resin> (raw)
In-Reply-To: <5542134.NUiWrkt5lN@peggleto-mobl.ger.corp.intel.com>

Hi Paul,

On Mon, Oct 26, 2015 at 08:08:29AM +0000, Paul Eggleton wrote:
> On Monday 26 October 2015 09:43:08 Jonathan Liu wrote:
> > [Support #16]
> >
> > Signed-off-by: Jonathan Liu <net147@gmail.com>
> > ---
> >  recipes-qt/qt5/qtbase_%.bbappend | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >  create mode 100644 recipes-qt/qt5/qtbase_%.bbappend
> >
> > diff --git a/recipes-qt/qt5/qtbase_%.bbappend
> > b/recipes-qt/qt5/qtbase_%.bbappend new file mode 100644
> > index 0000000..3e5e667
> > --- /dev/null
> > +++ b/recipes-qt/qt5/qtbase_%.bbappend
> > @@ -0,0 +1,6 @@
> > +do_configure_prepend_rpi() {
> > +    cat > ${S}/mkspecs/oe-device-extra.pri << 'EOF'
> > +EGLFS_DEVICE_INTEGRATION = eglfs_brcm
> > +QMAKE_LIBS_EGL = -lEGL -lGLESv2
> > +EOF
> > +}
>
> I'm wondering if this is a good idea or not. I appreciate the intention, but
> does bbappending non-machine-specific recipes like this play well when you have
> other machines enabled in the same distro?
>

But this change will be applied only for _rpi. How is this affecting other
machines?

--
Andrei Gherzan


  parent reply	other threads:[~2015-10-26  9:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 22:43 [meta-raspberrypi][PATCH v2] qtbase: enable Raspberry Pi support Jonathan Liu
2015-10-26  8:08 ` Paul Eggleton
2015-10-26  8:24   ` Jonathan Liu
2015-10-26 11:28     ` Otavio Salvador
2015-10-26 11:31       ` Jonathan Liu
2015-10-26 12:09         ` Otavio Salvador
2015-10-26  9:15   ` Andrei Gherzan [this message]
2015-10-26  9:41     ` Paul Eggleton
2015-10-26 10:48       ` Jonathan Liu
2015-10-26 10:54         ` Paul Eggleton
2015-10-26 11:10           ` Jonathan Liu
2015-10-26 11:45           ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026091549.GA19633@resin \
    --to=andrei@gherzan.ro \
    --cc=paul.eggleton@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.