From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Mon, 26 Oct 2015 09:27:11 +0100 Subject: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time In-Reply-To: References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <1445347435-2333-4-git-send-email-thomas.petazzoni@free-electrons.com> <20151026011036.2cb5b7a8@free-electrons.com> <20151026060925.32ff2034@free-electrons.com> Message-ID: <20151026092711.04193834@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Marcin Wojtas, On Mon, 26 Oct 2015 08:06:18 +0100, Marcin Wojtas wrote: > > Good :-) Hopefully the explanation in PATCH 5/5 is also clear enough. > > The Ascii-art is beutiful, indeed:) Glad to hear that my artistic skills are appreciated :) > Yes, you are right - without any pm_ops the driver works well after > suspend/resume in standby. However in the linux mem and standby is > treated exactly the same as pm sleep, so the same routines are > executed in both modes. Hence the s2ram support cannot spoil standby. Absolutely. It would be nicer if we knew in the ->suspend() and ->resume() hooks if we're doing a standby suspend, or a mem suspend, but IIRC, we don't have this information available. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbJZI1Z (ORCPT ); Mon, 26 Oct 2015 04:27:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:41722 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752376AbbJZI1W (ORCPT ); Mon, 26 Oct 2015 04:27:22 -0400 Date: Mon, 26 Oct 2015 09:27:11 +0100 From: Thomas Petazzoni To: Marcin Wojtas Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Lior Amsalem , Andrew Lunn , Tawfik Bayouk , linux-kernel@vger.kernel.org, Nadav Haklai , Gregory Clement , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth Subject: Re: [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Message-ID: <20151026092711.04193834@free-electrons.com> In-Reply-To: References: <1445347435-2333-1-git-send-email-thomas.petazzoni@free-electrons.com> <1445347435-2333-4-git-send-email-thomas.petazzoni@free-electrons.com> <20151026011036.2cb5b7a8@free-electrons.com> <20151026060925.32ff2034@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Marcin Wojtas, On Mon, 26 Oct 2015 08:06:18 +0100, Marcin Wojtas wrote: > > Good :-) Hopefully the explanation in PATCH 5/5 is also clear enough. > > The Ascii-art is beutiful, indeed:) Glad to hear that my artistic skills are appreciated :) > Yes, you are right - without any pm_ops the driver works well after > suspend/resume in standby. However in the linux mem and standby is > treated exactly the same as pm sleep, so the same routines are > executed in both modes. Hence the s2ram support cannot spoil standby. Absolutely. It would be nicer if we knew in the ->suspend() and ->resume() hooks if we're doing a standby suspend, or a mem suspend, but IIRC, we don't have this information available. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com