From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] x265: new package
Date: Mon, 26 Oct 2015 19:00:29 +0100 [thread overview]
Message-ID: <20151026180029.GA3788@free.fr> (raw)
In-Reply-To: <CAHCOiUSFUs4Nnr_r99LhkvOwS9HGZ19UPiGd0mwQAZadQDzLfA@mail.gmail.com>
Thijs, All,
On 2015-10-26 13:53 +0100, Thijs Vermeir spake thusly:
> On Sun, Oct 25, 2015 at 10:40 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > Thijs, care to check if changing true/false to ON/OFF still works,
> > please? If so, can you send an patch? This way, all our Cmake-based
> > packages will look the same, which is good for consistency.
> >
> > Regards,
> > Yann E. MORIN.
>
> Yes, I can look at it. To be clear you mean by the "standard" way:
> - create a patch to accept BUILD_SHARED_LIBS (and enable fPIC) and
> remove all the shared lib stuff from the mk file
No, it should not be needed to patch the sources of the package.
Just check if changing true/false in x265.mk to ON/OFF still works. If
so, do the change and send a patch to Buildroot to use ON/OFF instead of
true/false.
If it does not work, we will keep true/false.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-10-26 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 19:50 [Buildroot] [PATCH 1/2] x265: new package Thijs Vermeir
2015-10-24 19:50 ` [Buildroot] [PATCH 2/2] gst1-plugins-bad: add x265 plugin Thijs Vermeir
2015-10-25 21:30 ` Peter Korsgaard
2015-10-25 21:29 ` [Buildroot] [PATCH 1/2] x265: new package Peter Korsgaard
2015-10-25 21:40 ` Yann E. MORIN
2015-10-26 12:53 ` Thijs Vermeir
2015-10-26 18:00 ` Yann E. MORIN [this message]
2015-10-26 20:18 ` Thijs Vermeir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026180029.GA3788@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.