From: Stephen Boyd <sboyd@codeaurora.org>
To: Joachim Eastwood <manabian@gmail.com>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 3/3] clk: lpc18xx-cgu: fix potential system hang when disabling unused clocks
Date: Mon, 26 Oct 2015 15:06:41 -0700 [thread overview]
Message-ID: <20151026220641.GI19782@codeaurora.org> (raw)
In-Reply-To: <1445705724-20805-4-git-send-email-manabian@gmail.com>
On 10/24, Joachim Eastwood wrote:
> The clock consumer (CCU) of the CGU must be able to check if a CGU
> base clock is really running since access to the CCU registers
> requires a running base clock. Access with a disabled base clock will
> cause the system to hang. Fix this issue by adding code that check if
> the parent clock is running in the is_enabled clk_ops callback. Since
> certain clocks can be cascaded this must be added to all clock gates.
>
> The hang would occur if the boot ROM or boot loader didn't setup and
> enable the USB0 clock. Then when the clk framework tried to access
> the CCU register it would hang the system.
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-10-26 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 16:55 [PATCH v3 0/3] Fix unused clock disabling on LPC18xx Joachim Eastwood
2015-10-24 16:55 ` [PATCH v3 1/3] clk: Add clk_hw_is_enabled() for use by clk providers Joachim Eastwood
2015-10-26 22:06 ` Stephen Boyd
2015-10-24 16:55 ` [PATCH v3 2/3] clk: lpc18xx-ccu: fix potential system hang when disabling unused clocks Joachim Eastwood
2015-10-26 22:06 ` Stephen Boyd
2015-10-24 16:55 ` [PATCH v3 3/3] clk: lpc18xx-cgu: " Joachim Eastwood
2015-10-26 22:06 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026220641.GI19782@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.