From: Stephen Boyd <sboyd@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: agross@codeaurora.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, bjorn.andersson@sonymobile.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 3/8] clk: qcom: msm8916: Ignore sleep_clk_src registration errors
Date: Mon, 26 Oct 2015 15:44:34 -0700 [thread overview]
Message-ID: <20151026224434.GK19782@codeaurora.org> (raw)
In-Reply-To: <1445360280-2347-4-git-send-email-georgi.djakov@linaro.org>
On 10/20, Georgi Djakov wrote:
> We are moving the sleep clock to the DT. While all patches
> are merged, we will ignore sleep_clk_src registration errors.
> By ignoring this error, the msm8916 boards will continue booting
> during this transition period, otherwise the clock controller
> initialization will fail.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> drivers/clk/qcom/gcc-msm8916.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
> index 3c0668b12142..4bb7d8415ba7 100644
> --- a/drivers/clk/qcom/gcc-msm8916.c
> +++ b/drivers/clk/qcom/gcc-msm8916.c
> @@ -3364,10 +3364,8 @@ static int gcc_msm8916_probe(struct platform_device *pdev)
> if (IS_ERR(clk))
> return PTR_ERR(clk);
>
> - clk = clk_register_fixed_rate(dev, "sleep_clk_src", NULL,
> - CLK_IS_ROOT, 32768);
> - if (IS_ERR(clk))
> - return PTR_ERR(clk);
> + clk_register_fixed_rate(dev, "sleep_clk_src", NULL,
> + CLK_IS_ROOT, 32768);
>
And we might as well do the same check here too. We can remove
the code in a year or something.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-26 22:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 16:57 [PATCH v3 0/8] Add initial support for RPM clocks Georgi Djakov
2015-10-20 16:57 ` [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator Georgi Djakov
2015-10-22 2:52 ` Andy Gross
2015-10-27 23:17 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 2/8] clk: qcom: msm8916: Set the parent of xo to xo_board Georgi Djakov
2015-10-26 22:43 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 3/8] clk: qcom: msm8916: Ignore sleep_clk_src registration errors Georgi Djakov
2015-10-26 22:44 ` Stephen Boyd [this message]
2015-10-20 16:57 ` [PATCH v3 4/8] arm64: dts: qcom: 8x16: Add fixed rate sleep clock oscillator Georgi Djakov
2015-10-20 16:57 ` [PATCH v3 5/8] clk: qcom: Add support for RPM Clocks Georgi Djakov
2015-10-27 23:15 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 6/8] clk: qcom: Add RPM clock controller driver Georgi Djakov
2015-10-27 23:23 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 7/8] clk: qcom: msm8916: Use RPMCC if it is enabled Georgi Djakov
2015-10-20 16:58 ` [PATCH v3 8/8] clk: qcom: msm8916: Remove hard-coded sleep_clk_src Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026224434.GK19782@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.