Re: [Outreachy kernel] [PATCH 1/2] Staging: wilc1000: coreconfigurator: Remove irrelevant wrapper function

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Oct 26, 2015 at 08:21:05PM +0530, Shivani Bhardwaj wrote:
> Remove the function get_current_channel() and replace its calls by
> get_current_channel_802_11n() as the former function's definition
> involves only returning the value of latter function.
> Semantic patch used to find out the issue:
> 
> @@
> identifier f,g;
> @@
> 
> *f(...) {
>  return g(...); }
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 6dfe26d..1403a33 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -331,13 +331,6 @@ u8 get_current_channel_802_11n(u8 *pu8msa, u16 u16RxLen)
>  	return 0;  /* no MIB here */
>  }
>  
> -u8 get_current_channel(u8 *pu8msa, u16 u16RxLen)
> -{
> -	/* Extract current channel information from */
> -	/* the beacon/probe response frame          */
> -	return get_current_channel_802_11n(pu8msa, u16RxLen);
> -}
> -
>  /**
>   *  @brief                      parses the received 'N' message
>   *  @details
> @@ -425,8 +418,12 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>  		/* Get BSSID */
>  		get_BSSID(pu8msa, pstrNetworkInfo->au8bssid);
>  
> -		/* Get the current channel */
> -		pstrNetworkInfo->u8channel = get_current_channel(pu8msa, (u16RxLen + FCS_LEN));
> +		/* 
> +		 * Extract current channel information from
> +		 * the beacon/probe response frame          
> +		 */

Trailing whitespace :(

Always check your patches with checkpatch.pl so you don't get grumpy
emails from maintainers telling you to run your patches through
checkpatch.pl before sending them out...

thanks,

greg k-h