Re: [Outreachy kernel] [PATCH 3/6] staging: media: omap4iss: Replaces bit shift on 1 with BIT Macro

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Mon, Oct 26, 2015 at 08:48:06AM -0700, Amarjargal Gundjalam wrote:
> On Mon, 26 Oct 2015 15:46:27 +0100 (CET)
> Julia Lawall <julia.lawall@lip6.fr> wrote:
> 
> > > diff --git a/drivers/staging/media/omap4iss/iss_ipipe.h b/drivers/staging/media/omap4iss/iss_ipipe.h
> > > index c22d904..b8c1b8e0 100644
> > > --- a/drivers/staging/media/omap4iss/iss_ipipe.h
> > > +++ b/drivers/staging/media/omap4iss/iss_ipipe.h
> > > @@ -21,7 +21,7 @@ enum ipipe_input_entity {
> > >  	IPIPE_INPUT_IPIPEIF,
> > >  };
> > >
> > > -#define IPIPE_OUTPUT_VP		(1 << 0)
> > > +#define IPIPE_OUTPUT_VP				BIT(0)
> > 
> > Why did the amount of space change?
> 
> I tried to align it with the the others below it.
> 
> > 
> > >
> > >  /* Sink and source IPIPE pads */
> > >  #define IPIPE_PAD_SINK				0
> > > diff --git a/drivers/staging/media/omap4iss/iss_ipipeif.h b/drivers/staging/media/omap4iss/iss_ipipeif.h
> > > index cbdccb9..cf8a47a 100644
> > > --- a/drivers/staging/media/omap4iss/iss_ipipeif.h
> > > +++ b/drivers/staging/media/omap4iss/iss_ipipeif.h
> > > @@ -22,8 +22,8 @@ enum ipipeif_input_entity {
> > >  	IPIPEIF_INPUT_CSI2B
> > >  };
> > >
> > > -#define IPIPEIF_OUTPUT_MEMORY		(1 << 0)
> > > -#define IPIPEIF_OUTPUT_VP		(1 << 1)
> > > +#define IPIPEIF_OUTPUT_MEMORY			BIT(0)
> > > +#define IPIPEIF_OUTPUT_VP			BIT(1)
> > 
> > Here, however, you could take advantage of the opportunity to line them
> > up.  Maybe these are just a problem with tabs and the patch?
> > 
> 
> I did aligned them with tabs, maybe it's just a problem with patch formatting?

They looks aligned after applying.

regards
sudip