All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bogicevic Sasa <brutallesale@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues
Date: Tue, 27 Oct 2015 12:12:01 +0100	[thread overview]
Message-ID: <20151027111201.GA5033@gmail.com> (raw)
In-Reply-To: <20151027000939.GB30280@kroah.com>

Thanks, I get it now, Ill will group all changes and resend the patches
On 10/27/2015, Greg KH wrote:
>On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote:
>> On 10/26, Bogicevic Sasa wrote:
>> >Thanks for the review just sent the new patch,
>> >since change is very trivial I believe one liner like "fix all coding
>> >style issues in that and that file" is descriptive enough.
>
>No, not at all, that's not how we make kernel changes, look in the logs
>for specifics.  Each patch needs to be descriptive and only do one
>thing.  And as I said before "fix all coding style issues", is _NOT_
>"one thing".
>
>Please break it up into logical patches, _AND_ use checkpatch.pl to
>properly send the patches to the correct mailing list and developers.
>
>thanks,
>
>greg k-h

  reply	other threads:[~2015-10-27 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 16:36 [PATCH] Staging:drivers:wlan_ng: code style issues Bogicevic Sasa
2015-10-26 20:36 ` Greg KH
     [not found]   ` <20151026205555.GA9716@gmail.com>
     [not found]     ` <20151026220303.GA19566@kroah.com>
2015-10-26 22:09       ` Bogicevic Sasa
2015-10-26 22:21     ` Bogicevic Sasa
2015-10-27  0:09       ` Greg KH
2015-10-27 11:12         ` Bogicevic Sasa [this message]
2015-10-27  8:15 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027111201.GA5033@gmail.com \
    --to=brutallesale@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.