All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] Optimise grep action in power_management.
Date: Tue, 27 Oct 2015 17:35:17 +0100	[thread overview]
Message-ID: <20151027163516.GC22962@rei> (raw)
In-Reply-To: <1444872089-30094-1-git-send-email-sunyuan3@huawei.com>

Hi!
> root@p1:~# time (grep siblings /proc/cpuinfo > /dev/null)
> real	0m0.003s
> user	0m0.001s
> sys	0m0.002s
> root@p1:~# time (cat /proc/cpuinfo | grep siblings > /dev/null)
> real	0m0.004s
> user	0m0.002s
> sys	0m0.003s

I wouldn't say optimise in the commit message but rather simplify. Since
the difference in speed is not that big.

Otherwise the patches looks good.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2015-10-27 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  1:21 [LTP] [PATCH 1/2] Optimise grep action in power_management Yuan Sun
2015-10-15  1:21 ` [LTP] [PATCH 2/2] Optimise grep action in cpuset_syscall_test Yuan Sun
2015-11-06  9:01   ` Jan Stancek
2015-11-16 16:37     ` Cyril Hrubis
2015-11-16 16:50       ` Jan Stancek
2015-11-16 17:10         ` Cyril Hrubis
2015-10-27 16:35 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027163516.GC22962@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.