From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: cachetype: fix definitions of ICACHEF_* flags
Date: Tue, 27 Oct 2015 16:42:13 +0000 [thread overview]
Message-ID: <20151027164213.GL3091@leverpostej> (raw)
In-Reply-To: <1445947555-2109-2-git-send-email-will.deacon@arm.com>
On Tue, Oct 27, 2015 at 12:05:55PM +0000, Will Deacon wrote:
> test_bit and set_bit take the bit number to operate on, rather than a
> mask. This patch fixes the ICACHEF_* definitions so that they represent
> the bit index in __icache_flags as opposed to the mask returned by the
> BIT macro.
>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
At least they were used consistently, so this is a cleanup rather than a
fix.
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/include/asm/cachetype.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/include/asm/cachetype.h b/arch/arm64/include/asm/cachetype.h
> index da2fc9e3cedd..f5588692f1d4 100644
> --- a/arch/arm64/include/asm/cachetype.h
> +++ b/arch/arm64/include/asm/cachetype.h
> @@ -34,8 +34,8 @@
>
> #define CTR_L1IP(ctr) (((ctr) >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK)
>
> -#define ICACHEF_ALIASING BIT(0)
> -#define ICACHEF_AIVIVT BIT(1)
> +#define ICACHEF_ALIASING 0
> +#define ICACHEF_AIVIVT 1
>
> extern unsigned long __icache_flags;
>
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2015-10-27 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:05 [PATCH 1/2] arm64: cpufeature: declare enable_cpu_capabilities as static Will Deacon
2015-10-27 12:05 ` [PATCH 2/2] arm64: cachetype: fix definitions of ICACHEF_* flags Will Deacon
2015-10-27 16:42 ` Mark Rutland [this message]
2015-10-28 18:37 ` [PATCH 1/2] arm64: cpufeature: declare enable_cpu_capabilities as static Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027164213.GL3091@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.