From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16 Date: Tue, 27 Oct 2015 18:51:34 +0200 Message-ID: <20151027165134.GK1548@lahna.fi.intel.com> References: <20151019165914.GA22867@sophia> <20151027142343.GI1548@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: William Breathitt Gray , Andreas Bofjall , Simon Guinot , Diego Elio =?iso-8859-1?Q?Petten=F2?= , Daniel Krueger , Bruno Randolf , Vivien Didelot , Alexandre Courbot , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Tue, Oct 27, 2015 at 05:42:23PM +0100, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 3:23 PM, Mika Westerberg > wrote: > > On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: > >> > +menu "ISA GPIO drivers" > >> > + > >> > +config GPIO_104_IDIO_16 > >> > + tristate "ACCES 104-IDIO-16 GPIO support" > >> > + depends on X86 > >> > + help > >> > + Enables GPIO support for the ACCES 104-IDIO-16 family. > >> > + > >> > +endmenu > >> > >> I have five other drivers using port-based I/O: > >> > >> gpio-f7188x.c > >> gpio-it87.c > >> gpio-sch.c > >> gpio-sch311x.c > >> gpio-ts5500.c > >> > >> Do you think it makes sense to move all of these in under > >> the "ISA GPIO drivers" menu as well? I guess they all require > >> ISA after all. > >> > >> (Added their maintainers to the To: line so I can get some input > >> on this.) > > > > Not all of them actually require ISA. For example gpio-sch is part of an > > MFD device which is a PCI device. PCI bus also has notion of I/O ports. > > Hm, is there a more fitting symbol we should sort it under, which > means thingofabob-that-has-portmapped I/O? Well, there's already "Memory mapped GPIO drivers" so how about "I/O mapped GPIO drivers"?